Differential D34430

tslog.4: Document TSLOG
ClosedPublic
Actions

Authored by 0mp on Mar 3 2022, 9:25 PM.

Tags

None

Referenced Files

	F105342344: D34430.id103460.diff
	Sun, Dec 15, 3:27 AM

	F105335996: D34430.diff
	Sun, Dec 15, 1:43 AM

	Unknown Object (File)
	Mon, Dec 2, 9:41 PM

	Unknown Object (File)
	Fri, Nov 29, 11:02 PM

	Unknown Object (File)
	Wed, Nov 27, 2:18 AM

	Unknown Object (File)
	Mon, Nov 25, 7:54 AM

	Unknown Object (File)
	Nov 14 2024, 9:21 PM

	Unknown Object (File)
	Oct 3 2024, 10:23 AM

View All 61 Files

Subscribers

Details

Reviewers

cperciva
mhorne
manu
debdrup

Group Reviewers

Commits

rGb85d0d603c57: tslog.4: Document TSLOG
rG759880b587fa: tslog.4: Document TSLOG
rG5675bb582985: tslog.4: Document TSLOG

Summary

Based on commit messages and Colin Percival's presentation
from BSDCan 2018 [1].

[1]: https://papers.freebsd.org/2018/bsdcan/percival-Profiling_the_FreeBSD_kernel_boot.files/percival-Profiling_the_FreeBSD_kernel_boot.pdf

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

0mp created this revision.Mar 3 2022, 9:25 PM

Herald added a reviewer: manpages. · View Herald TranscriptMar 3 2022, 9:25 PM

Herald added a subscriber: imp. · View Herald Transcript

0mp requested review of this revision.Mar 3 2022, 9:25 PM

Harbormaster completed remote builds in B44635: Diff 103459.Mar 3 2022, 9:25 PM

0mp added inline comments.Mar 3 2022, 9:27 PM

share/man/man4/tslog.4
97	Let me know of you remember when TSLOG got introduced. This history section should probably be moved to a new manual page called tracing(7) or omitted.

cperciva added inline comments.Mar 3 2022, 9:49 PM

share/man/man4/tslog.4
47	"is able to trace the boot loader, kernel initialization, and userland processes"
76	s/kernel/loader and kernel/
97	December 31st, 2017 for the original kernel-only bits. Summer 2021 for the boot loader and userland bits.

Address Colin's comments
Mention that TSLOG appeared in 12.0, and was extended in 14.0

Harbormaster completed remote builds in B44636: Diff 103460.Mar 3 2022, 10:00 PM

Thanks, @cperciva!

Manual page looks good to me.

This revision is now accepted and ready to land.Mar 4 2022, 5:46 PM

Thanks, @debdrup!

I'll wait for a review from a src committer before I commit the patch.

Approved with src-committer hat.

Closed by commit rG5675bb582985: tslog.4: Document TSLOG (authored by 0mp). · Explain WhyMar 4 2022, 7:38 PM

This revision was automatically updated to reflect the committed changes.

0mp added a commit: rG5675bb582985: tslog.4: Document TSLOG.

Thanks!

0mp added a commit: rG759880b587fa: tslog.4: Document TSLOG.Mar 11 2022, 10:05 AM

0mp added a commit: rGb85d0d603c57: tslog.4: Document TSLOG.Mar 11 2022, 10:09 AM

Revision Contents
Changeset List

Path

Size

share/

man/

man4/

1 line

135 lines

Diff 103505

share/man/man4/Makefile

Loading...

share/man/man4/tslog.4

Loading...