Page MenuHomeFreeBSD
Differential D41905

ObsoleteFiles.inc: do not remove ofwdump.8 on powerpc64le
ClosedPublic
Actions

Authored by pkubaj on Sep 18 2023, 11:33 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 12:10 PM
Unknown Object (File)
Tue, May 7, 12:12 AM
Unknown Object (File)
Thu, May 2, 9:10 PM
Unknown Object (File)
Thu, May 2, 3:12 AM
Unknown Object (File)
Mon, Apr 29, 7:25 AM
Unknown Object (File)
Wed, Apr 10, 12:55 PM
Unknown Object (File)
Mar 5 2024, 4:29 AM
Unknown Object (File)
Feb 17 2024, 10:43 AM
View All 16 Files
Subscribers
imp
jhibbits

Details

Reviewers
mhorne
Group Reviewers
PowerPC
Commits
rG56a2b5d640f7: ObsoleteFiles.inc: only leave ofwdump.8.gz when WITH_FDT is set
rG4cf8075264c9: ObsoleteFiles.inc: only leave ofwdump.8.gz when WITH_FDT is set
Summary

ofwdump is used on powerpc64le. Also switch to just checking for riscv64,
sparc64 and mips are not supported and other architectures may use ofwdump.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 53680
Build 50571: arc lint + arc unit

Event Timeline

pkubaj created this revision.Sep 18 2023, 11:33 PM
Herald added a subscriber: imp. · View Herald TranscriptSep 18 2023, 11:33 PM
pkubaj requested review of this revision.Sep 18 2023, 11:33 PM
Harbormaster completed remote builds in B53632: Diff 127517.Sep 18 2023, 11:33 PM
jhibbits added a subscriber: jhibbits.Sep 19 2023, 2:36 AM
jhibbits added inline comments.
ObsoleteFiles.inc
17654–17655

Shouldn't amd64 and i386 be included here?

mhorne requested changes to this revision.Sep 20 2023, 6:15 PM

The existing logic appears to be outdated. ofwdump(8) is installed for every architecture except amd64 and i386. The SUBDIR is specified in, e.g. usr.sbin/Makefile.aarch64.

I think the most correct fix would be to move this entry to tools/build/mk/OptionalObsoleteFile.inc, and have it dependent on the MK_FDT build knob, but this is one step further.

This revision now requires changes to proceed.Sep 20 2023, 6:15 PM
pkubaj updated this revision to Diff 127661.Sep 22 2023, 11:49 PM

Address mhorne's feedback.

Harbormaster completed remote builds in B53680: Diff 127661.Sep 22 2023, 11:49 PM
mhorne accepted this revision.Sep 25 2023, 5:28 PM
This revision is now accepted and ready to land.Sep 25 2023, 5:28 PM
mhorne added a child revision: D41977: ofwdump: install dependent on MK_FDT.Sep 25 2023, 5:31 PM
pkubaj closed this revision.Oct 1 2023, 9:58 PM

Committed in 4cf8075264c9db8f3e39a1f17def58cda8803853.

pkubaj added a commit: rG4cf8075264c9: ObsoleteFiles.inc: only leave ofwdump.8.gz when WITH_FDT is set.Oct 2 2023, 4:44 PM
pkubaj added a commit: rG56a2b5d640f7: ObsoleteFiles.inc: only leave ofwdump.8.gz when WITH_FDT is set.Oct 4 2023, 3:48 PM

Revision Contents
Changeset List

PathSize
5 lines
tools/
build/
mk/
4 lines

Diff 127661

View Options

ObsoleteFiles.inc

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...