powerpc64*: port mlx5, OFED, KTLS and krping
ClosedPublic
Actions

Authored by pkubaj on Feb 25 2023, 9:20 PM.

Details

Reviewers

Group Reviewers

Commits

rGe552cac3d7d9: powerpc64*: port mlx5, OFED, KTLS and krping
rG83d6d8877ef7: powerpc64*: port mlx5, OFED, KTLS and krping

Summary

This review ports mlx5 driver, kernel's OFED stack (userland is already enabled), KTLS and krping to powerpc64 and powerpc64le.

krping requires a small change since it uses assembly for amd64 / i386.

NOTE: On powerpc64le RDMA works fine in the userspace with libmlx5, but on powerpc64 it does not. The problem is that contrib/ofed/libmlx5/doorbell.h checks for SIZEOF_LONG but this macro exists on neither powerpc64* nor amd64. Thus, the file silently goes to the fallback function written for 32-bit architectures. It works fine on little-endian architectures, but causes a hard fail on big-endian. It's possible it may also cause some runtime issues on little-endian. Thus, on powerpc64 I verified that RDMA works with krping.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

pkubaj created this revision.Feb 25 2023, 9:20 PM

Herald added subscribers: jhibbits, emaste, imp, bdrewery. · View Herald TranscriptFeb 25 2023, 9:20 PM

pkubaj requested review of this revision.Feb 25 2023, 9:20 PM

Harbormaster completed remote builds in B50019: Diff 117936.Feb 25 2023, 9:20 PM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 25 2023, 11:57 PM

Closed by commit rG83d6d8877ef7: powerpc64*: port mlx5, OFED, KTLS and krping (authored by pkubaj). · Explain Why

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rG83d6d8877ef7: powerpc64*: port mlx5, OFED, KTLS and krping.

pkubaj added a reverting change: rGf5a1c871e6a7: Revert "powerpc64*: port mlx5, OFED, KTLS and krping".

pkubaj reopened this revision.Feb 26 2023, 12:08 AM

Have a look at my comment. Looks good!

sys/contrib/rdma/krping/krping.c
77	Is the builting supported for amd64 and i386 aswell?

pkubaj added inline comments.Feb 26 2023, 2:21 PM

sys/contrib/rdma/krping/krping.c
77	Apparently it is, but I have not tested on amd64 and i386. According to https://clang.llvm.org/docs/LanguageExtensions.html#builtin-functions, it works everywhere.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 26 2023, 10:39 PM

Closed by commit rGe552cac3d7d9: powerpc64*: port mlx5, OFED, KTLS and krping (authored by pkubaj). · Explain Why

This revision was automatically updated to reflect the committed changes.

pkubaj added a commit: rGe552cac3d7d9: powerpc64*: port mlx5, OFED, KTLS and krping.

FWIW, I would probably have split this up into a few commits to make it easier for someone in the future to bisect if this triggers some kind of breakage (e.g. KERN_TLS separate from base mlx5 separate from OFED)