Page MenuHomeFreeBSD

netinet*: de-void control input IP protocol methods
ClosedPublic

Authored by glebius on Sep 26 2022, 7:02 PM.

Details

Summary

After decoupling of protosw(9) and IP wire protocols in 78b1fc05b205 for
IPv4 we got vector ip_ctlprotox[] that is executed only and only from
icmp_input() and respectively for IPv6 we got ip6_ctlprotox[] executed
only and only from icmp6_input(). This allows to use protocol specific
argument types in these methods instead of struct sockaddr and void.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

melifaro added inline comments.
sys/netinet/tcp_subr.c
2857–2858

Q: why not pass the actual address instead of struct sockaddr_in?

This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2022, 3:58 AM
This revision was automatically updated to reflect the committed changes.