Paths

Table of Contentst

Differential D36727

netinet*: de-void control input IP protocol methods
ClosedPublic
Actions

Authored by glebius on Sep 26 2022, 7:02 PM.

Tags

None

Referenced Files

	F134651900: D36727.id111015.diff
	Mon, Nov 3, 9:04 PM

	F134651782: D36727.id.diff
	Mon, Nov 3, 9:03 PM

	F134651666: D36727.diff
	Mon, Nov 3, 9:02 PM

	Unknown Object (File)
	Sun, Nov 2, 5:44 AM

	Unknown Object (File)
	Sat, Nov 1, 12:36 PM

	Unknown Object (File)
	Tue, Oct 28, 4:21 AM

	Unknown Object (File)
	Sun, Oct 26, 1:04 PM

	Unknown Object (File)
	Sun, Oct 26, 4:30 AM

Subscribers

Details

Reviewers

Group Reviewers

network
transport

Commits

rG43d39ca7e518: netinet*: de-void control input IP protocol methods

Summary

After decoupling of protosw(9) and IP wire protocols in 78b1fc05b205 for
IPv4 we got vector ip_ctlprotox[] that is executed only and only from
icmp_input() and respectively for IPv6 we got ip6_ctlprotox[] executed
only and only from icmp6_input(). This allows to use protocol specific
argument types in these methods instead of struct sockaddr and void.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 47546
Build 44433: arc lint + arc unit

Event Timeline

glebius created this revision.Sep 26 2022, 7:02 PM

Herald added a reviewer: transport. · View Herald TranscriptSep 26 2022, 7:02 PM

Herald added subscribers: melifaro, ae, imp. · View Herald Transcript

glebius requested review of this revision.Sep 26 2022, 7:02 PM

Harbormaster completed remote builds in B47546: Diff 111015.Sep 26 2022, 7:02 PM

glebius added a parent revision: D36726: netinet6: retire ip6protosw.h.Sep 26 2022, 7:02 PM

melifaro accepted this revision as: network, melifaro.Sep 27 2022, 11:02 AM

melifaro added inline comments.

sys/netinet/tcp_subr.c
2845	Q: why not pass the actual address instead of `struct sockaddr_in`?

This revision was not accepted when it landed; it landed in state Needs Review.Oct 4 2022, 3:58 AM

Closed by commit rG43d39ca7e518: netinet*: de-void control input IP protocol methods (authored by glebius). · Explain Why

This revision was automatically updated to reflect the committed changes.

glebius added a commit: rG43d39ca7e518: netinet*: de-void control input IP protocol methods.

Revision Contents
Changeset List

Path

Size

sys/

netinet/

4 lines

7 lines

4 lines

11 lines

2 lines

64 lines

2 lines

26 lines

netinet6/

5 lines

4 lines

14 lines

9 lines

19 lines

16 lines

2 lines

6 lines

39 lines

4 lines

Diff 111015

sys/netinet/ip_icmp.c

Loading...

sys/netinet/ip_var.h

Loading...

sys/netinet/raw_ip.c

Loading...

sys/netinet/sctp_usrreq.c

Loading...

sys/netinet/sctp_var.h

Loading...

sys/netinet/tcp_subr.c

Loading...

sys/netinet/tcp_var.h

Loading...

sys/netinet/udp_usrreq.c

Loading...

sys/netinet6/icmp6.c

Loading...

sys/netinet6/in6_pcb.h

Loading...

sys/netinet6/in6_pcb.c

Loading...

sys/netinet6/ip6_var.h

Loading...

sys/netinet6/raw_ip6.c

Loading...

sys/netinet6/sctp6_usrreq.c

Loading...

sys/netinet6/sctp6_var.h

Loading...

sys/netinet6/tcp6_var.h

Loading...

sys/netinet6/udp6_usrreq.c

Loading...

sys/netinet6/udp6_var.h

Loading...