Page MenuHomeFreeBSD

tcp: refactor tcp_autorcvbuf() and associated sysctls
AcceptedPublic

Authored by glebius on Wed, Oct 14, 6:58 PM.
Tags
None
Referenced Files
F176007148: D60731.id189924.diff
Thu, Oct 15, 6:14 AM
F175994482: D60731.id189924.diff
Thu, Oct 15, 3:17 AM
F175993625: D60731.diff
Thu, Oct 15, 3:04 AM
F175993443: D60731.id189924.diff
Thu, Oct 15, 3:02 AM
F175991644: D60731.diff
Thu, Oct 15, 2:39 AM
F175991198: D60731.id.diff
Thu, Oct 15, 2:33 AM
F175989302: D60731.diff
Thu, Oct 15, 2:06 AM
Subscribers

Details

Reviewers
tuexen
gnn
Group Reviewers
transport
Summary

Run the entire function under the socket buffer lock. Make it responsible
to set the new limit or clear SB_AUTOSIZE in case of a failure. Use
unsigned type for newsize, that matches both the sb_hiwat type and min()
argument types. Make byte counter in the tcpcb unsigned, too. Make the
sizing tunables unsigned, and make the switching tunable a boolean. Don't
execute Dtrace probe in case of a failure. Simplify the Dtrace probe to
report only relevant information, the previous probe looked more like a
leftover from a debugging session.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 78220
Build 75103: arc lint + arc unit