Lgtm

MIPS has been removed from the tree

Added a comment indicating that PIE is incompatible with -mno-abicalls. Thanks, @emaste.

@alfredo/ @fernando.valle_eldorado.org.br Are you planning to commit this soon?

LGTM

Grammar correction suggestions in code comments.

Minor grammar suggestions but otherwise looks good to me. Thanks!

'if _BYTE_ORDER' removed, making the code more generic, as suggested in the comments of this revision. Comments were also added explaining why endian conversion is necessary.

In D25416#569712, @fernando.valle_eldorado.org.br wrote:

@arichardson Which freebsd .img revision are you using?

In D25416#569712, @fernando.valle_eldorado.org.br wrote:

@arichardson Which freebsd .img revision are you using?

@arichardson Which freebsd .img revision are you using?

I can confirm that this makes virtio-rng work again for MIPS64. LGTM if you apply @alfredo's suggestions.

In this way the specificity of the mips is removed, the adjustments of the bus_space in the vtpci_* defines makes the code more generic.

I stepped through MIPS init in QEMU and it turns out MALTA ends up with

p sc->vtpci_res->r_bustag
$7 = (bus_space_tag_t) 0xffffffff809aefc0 <gt_pci_space>

More respose to markj feedback

Note that for instance x86 has similar issue, because hardware is free to speculatively walk page tables and load any valid PTE or intermediate paging structure. There all page table entries clearing functions take the free list pointer, where the freed page table is put. Only after the caller did IPI to invalidate TLB for cleared PTE, the pages from the list can be freed.

This looks reasonable to me aside from the style nits.

Revised version as per markj's feedback

Now without D24523 included