Page MenuHomeFreeBSD

MIPSUmbrella
ActivePublic

Recent Activity

Jul 28 2020

alfredo closed D25416: Make access to VirtIO configuration to mips architecture..
Jul 28 2020, 11:24 AM · PowerPC, MIPS
arichardson accepted D25416: Make access to VirtIO configuration to mips architecture..

@alfredo/ @fernando.valle_eldorado.org.br Are you planning to commit this soon?

Jul 28 2020, 10:38 AM · PowerPC, MIPS

Jul 24 2020

alfredo accepted D25416: Make access to VirtIO configuration to mips architecture..

LGTM

Jul 24 2020, 3:48 AM · PowerPC, MIPS

Jul 23 2020

fernando.valle_eldorado.org.br updated the diff for D25416: Make access to VirtIO configuration to mips architecture..

Grammar correction suggestions in code comments.

Jul 23 2020, 6:52 PM · PowerPC, MIPS

Jul 22 2020

arichardson accepted D25416: Make access to VirtIO configuration to mips architecture..

Minor grammar suggestions but otherwise looks good to me. Thanks!

Jul 22 2020, 1:34 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br updated the diff for D25416: Make access to VirtIO configuration to mips architecture..

'if _BYTE_ORDER' removed, making the code more generic, as suggested in the comments of this revision. Comments were also added explaining why endian conversion is necessary.

Jul 22 2020, 12:37 PM · PowerPC, MIPS

Jul 20 2020

arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

@arichardson Which freebsd .img revision are you using?

Jul 20 2020, 2:15 PM · PowerPC, MIPS
arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

@arichardson Which freebsd .img revision are you using?

Jul 20 2020, 12:28 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br added a comment to D25416: Make access to VirtIO configuration to mips architecture..

@arichardson Which freebsd .img revision are you using?

Jul 20 2020, 12:22 PM · PowerPC, MIPS

Jul 14 2020

arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

I can confirm that this makes virtio-rng work again for MIPS64. LGTM if you apply @alfredo's suggestions.

Jul 14 2020, 11:36 AM · PowerPC, MIPS

Jul 8 2020

alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 8 2020, 6:01 PM · PowerPC, MIPS
alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 8 2020, 4:50 PM · PowerPC, MIPS
alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 8 2020, 2:03 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br updated the diff for D25416: Make access to VirtIO configuration to mips architecture..

In this way the specificity of the mips is removed, the adjustments of the bus_space in the vtpci_* defines makes the code more generic.

Jul 8 2020, 12:24 PM · PowerPC, MIPS

Jul 6 2020

alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 6 2020, 10:08 PM · PowerPC, MIPS

Jul 2 2020

jrtc27 added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 2 2020, 2:48 PM · PowerPC, MIPS
afscoelho_gmail.com added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 2 2020, 2:45 PM · PowerPC, MIPS

Jun 24 2020

sbruno abandoned D2535: New, experimental PMAP implementation for MIPS64.
Jun 24 2020, 7:42 PM · MIPS
arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

I stepped through MIPS init in QEMU and it turns out MALTA ends up with

p sc->vtpci_res->r_bustag
$7 = (bus_space_tag_t) 0xffffffff809aefc0 <gt_pci_space>
Jun 24 2020, 1:52 PM · PowerPC, MIPS
jrtc27 added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jun 24 2020, 1:39 PM · PowerPC, MIPS
arichardson added a reviewer for D25416: Make access to VirtIO configuration to mips architecture.: jrtc27.
Jun 24 2020, 1:37 PM · PowerPC, MIPS
arichardson added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jun 24 2020, 1:37 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br added projects to D25416: Make access to VirtIO configuration to mips architecture.: MIPS, PowerPC.
Jun 24 2020, 1:22 PM · PowerPC, MIPS

Apr 24 2020

markj closed D24523: mips pmap: pmap_emulate_modified race fix.
Apr 24 2020, 9:22 PM · MIPS
markj closed D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 24 2020, 9:21 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org updated the diff for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

More respose to markj feedback

Apr 24 2020, 2:40 PM · MIPS
kib accepted D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

Note that for instance x86 has similar issue, because hardware is free to speculatively walk page tables and load any valid PTE or intermediate paging structure. There all page table entries clearing functions take the free list pointer, where the freed page table is put. Only after the caller did IPI to invalidate TLB for cleared PTE, the pages from the list can be freed.

Apr 24 2020, 11:04 AM · MIPS

Apr 23 2020

markj accepted D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

This looks reasonable to me aside from the style nits.

Apr 23 2020, 2:21 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org updated the diff for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

Revised version as per markj's feedback

Apr 23 2020, 1:20 AM · MIPS
freebsdphab-AX9_cmx.ietfng.org added inline comments to D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 23 2020, 1:18 AM · MIPS

Apr 22 2020

markj added inline comments to D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 22 2020, 3:43 PM · MIPS
markj accepted D24523: mips pmap: pmap_emulate_modified race fix.
Apr 22 2020, 3:21 PM · MIPS
kib accepted D24523: mips pmap: pmap_emulate_modified race fix.
Apr 22 2020, 11:28 AM · MIPS

Apr 21 2020

freebsdphab-AX9_cmx.ietfng.org retitled D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss from Fix two races in the MIPS pmap to mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 21 2020, 6:40 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org updated the diff for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

Now without D24523 included

Apr 21 2020, 6:39 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org added reviewers for D24523: mips pmap: pmap_emulate_modified race fix: kib, markj, brett_gutste.in.
Apr 21 2020, 6:37 PM · MIPS

Apr 20 2020

kib added a comment to D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

I believe it is better to split the review into two. The pmap_emulate_modified() looks good to me, and I do not see why the other part should block this one.

Apr 20 2020, 1:34 AM · MIPS

Apr 18 2020

freebsdphab-AX9_cmx.ietfng.org added a reviewer for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss: brett_gutste.in.
Apr 18 2020, 11:15 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org added reviewers for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss: kib, markj.
Apr 18 2020, 11:14 PM · MIPS

Sep 4 2019

ray added a member for MIPS: ray.
Sep 4 2019, 9:05 PM

Mar 16 2019

jmallett abandoned D19172: Remove 32-bit SWARM kernels and supporting code..
Mar 16 2019, 6:15 AM · MIPS

Feb 12 2019

jmallett created D19172: Remove 32-bit SWARM kernels and supporting code..
Feb 12 2019, 9:59 PM · MIPS

Dec 22 2017

kib closed D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 11:27 PM · MIPS
jhb accepted D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 11:07 PM · MIPS
kib updated the diff for D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..

Remove mips 32bit atomic_load/store_64.

Dec 22 2017, 9:58 PM · MIPS
imp added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
In D13586#284245, @jhb wrote:

Yes, let's kill these and fix DDB instead.

Dec 22 2017, 8:44 PM · MIPS
jhb added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..

Yes, let's kill these and fix DDB instead.

Dec 22 2017, 8:40 PM · MIPS
kib added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
In D13586#284229, @jhb wrote:

BTW, I looked and the only place atomic_load_64 and atomic_store_64 are used in sys/mips is for DDB (db_read_bytes and db_write_bytes in sys/mips/mips/db_interface.c). It is not clear to me that this actually needs to be near this fancy. Most architectures just do a simple byte loop. Only 32-bit arm, mips, and powerpc attempt to handle accesses for exact word-size specially. arm doesn't try to handle 64-bit accesses with this kind of magic. powerpc just uses a 'uint64_t' load and store via C the same as it does for other word sizes. I suspect the db_read/write_bytes can just be simplified to match what powerpc does and and use simple C load/store and then these functions can be removed.

Dec 22 2017, 6:28 PM · MIPS
jhb added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..

BTW, I looked and the only place atomic_load_64 and atomic_store_64 are used in sys/mips is for DDB (db_read_bytes and db_write_bytes in sys/mips/mips/db_interface.c). It is not clear to me that this actually needs to be near this fancy. Most architectures just do a simple byte loop. Only 32-bit arm, mips, and powerpc attempt to handle accesses for exact word-size specially. arm doesn't try to handle 64-bit accesses with this kind of magic. powerpc just uses a 'uint64_t' load and store via C the same as it does for other word sizes. I suspect the db_read/write_bytes can just be simplified to match what powerpc does and and use simple C load/store and then these functions can be removed.

Dec 22 2017, 6:14 PM · MIPS
kib added inline comments to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 5:39 PM · MIPS