Page MenuHomeFreeBSD
Feed Advanced Search

Jul 28 2020

alfredo closed D25416: Make access to VirtIO configuration to mips architecture..
Jul 28 2020, 11:24 AM · PowerPC, MIPS
arichardson accepted D25416: Make access to VirtIO configuration to mips architecture..

@alfredo/ @fernando.valle_eldorado.org.br Are you planning to commit this soon?

Jul 28 2020, 10:38 AM · PowerPC, MIPS

Jul 24 2020

alfredo accepted D25416: Make access to VirtIO configuration to mips architecture..

LGTM

Jul 24 2020, 3:48 AM · PowerPC, MIPS

Jul 23 2020

fernando.valle_eldorado.org.br updated the diff for D25416: Make access to VirtIO configuration to mips architecture..

Grammar correction suggestions in code comments.

Jul 23 2020, 6:52 PM · PowerPC, MIPS

Jul 22 2020

arichardson accepted D25416: Make access to VirtIO configuration to mips architecture..

Minor grammar suggestions but otherwise looks good to me. Thanks!

Jul 22 2020, 1:34 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br updated the diff for D25416: Make access to VirtIO configuration to mips architecture..

'if _BYTE_ORDER' removed, making the code more generic, as suggested in the comments of this revision. Comments were also added explaining why endian conversion is necessary.

Jul 22 2020, 12:37 PM · PowerPC, MIPS

Jul 20 2020

arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

@arichardson Which freebsd .img revision are you using?

Jul 20 2020, 2:15 PM · PowerPC, MIPS
arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

@arichardson Which freebsd .img revision are you using?

Jul 20 2020, 12:28 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br added a comment to D25416: Make access to VirtIO configuration to mips architecture..

@arichardson Which freebsd .img revision are you using?

Jul 20 2020, 12:22 PM · PowerPC, MIPS

Jul 14 2020

arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

I can confirm that this makes virtio-rng work again for MIPS64. LGTM if you apply @alfredo's suggestions.

Jul 14 2020, 11:36 AM · PowerPC, MIPS

Jul 8 2020

alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 8 2020, 6:01 PM · PowerPC, MIPS
alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 8 2020, 4:50 PM · PowerPC, MIPS
alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 8 2020, 2:03 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br updated the diff for D25416: Make access to VirtIO configuration to mips architecture..

In this way the specificity of the mips is removed, the adjustments of the bus_space in the vtpci_* defines makes the code more generic.

Jul 8 2020, 12:24 PM · PowerPC, MIPS

Jul 6 2020

alfredo added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 6 2020, 10:08 PM · PowerPC, MIPS

Jul 2 2020

jrtc27 added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 2 2020, 2:48 PM · PowerPC, MIPS
afscoelho_gmail.com added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jul 2 2020, 2:45 PM · PowerPC, MIPS

Jun 24 2020

sbruno abandoned D2535: New, experimental PMAP implementation for MIPS64.
Jun 24 2020, 7:42 PM · MIPS
arichardson added a comment to D25416: Make access to VirtIO configuration to mips architecture..

I stepped through MIPS init in QEMU and it turns out MALTA ends up with

p sc->vtpci_res->r_bustag
$7 = (bus_space_tag_t) 0xffffffff809aefc0 <gt_pci_space>
Jun 24 2020, 1:52 PM · PowerPC, MIPS
jrtc27 added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jun 24 2020, 1:39 PM · PowerPC, MIPS
arichardson added a reviewer for D25416: Make access to VirtIO configuration to mips architecture.: jrtc27.
Jun 24 2020, 1:37 PM · PowerPC, MIPS
arichardson added inline comments to D25416: Make access to VirtIO configuration to mips architecture..
Jun 24 2020, 1:37 PM · PowerPC, MIPS
fernando.valle_eldorado.org.br added projects to D25416: Make access to VirtIO configuration to mips architecture.: MIPS, PowerPC.
Jun 24 2020, 1:22 PM · PowerPC, MIPS

Apr 24 2020

markj closed D24523: mips pmap: pmap_emulate_modified race fix.
Apr 24 2020, 9:22 PM · MIPS
markj closed D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 24 2020, 9:21 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org updated the diff for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

More respose to markj feedback

Apr 24 2020, 2:40 PM · MIPS
kib accepted D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

Note that for instance x86 has similar issue, because hardware is free to speculatively walk page tables and load any valid PTE or intermediate paging structure. There all page table entries clearing functions take the free list pointer, where the freed page table is put. Only after the caller did IPI to invalidate TLB for cleared PTE, the pages from the list can be freed.

Apr 24 2020, 11:04 AM · MIPS

Apr 23 2020

markj accepted D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

This looks reasonable to me aside from the style nits.

Apr 23 2020, 2:21 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org updated the diff for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

Revised version as per markj's feedback

Apr 23 2020, 1:20 AM · MIPS
freebsdphab-AX9_cmx.ietfng.org added inline comments to D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 23 2020, 1:18 AM · MIPS

Apr 22 2020

markj added inline comments to D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 22 2020, 3:43 PM · MIPS
markj accepted D24523: mips pmap: pmap_emulate_modified race fix.
Apr 22 2020, 3:21 PM · MIPS
kib accepted D24523: mips pmap: pmap_emulate_modified race fix.
Apr 22 2020, 11:28 AM · MIPS

Apr 21 2020

freebsdphab-AX9_cmx.ietfng.org retitled D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss from Fix two races in the MIPS pmap to mips _pmap_unwire_ptp races MipsDoTLBMiss.
Apr 21 2020, 6:40 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org updated the diff for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

Now without D24523 included

Apr 21 2020, 6:39 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org added reviewers for D24523: mips pmap: pmap_emulate_modified race fix: kib, markj, brett_gutste.in.
Apr 21 2020, 6:37 PM · MIPS

Apr 20 2020

kib added a comment to D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss.

I believe it is better to split the review into two. The pmap_emulate_modified() looks good to me, and I do not see why the other part should block this one.

Apr 20 2020, 1:34 AM · MIPS

Apr 18 2020

freebsdphab-AX9_cmx.ietfng.org added a reviewer for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss: brett_gutste.in.
Apr 18 2020, 11:15 PM · MIPS
freebsdphab-AX9_cmx.ietfng.org added reviewers for D24491: mips _pmap_unwire_ptp races MipsDoTLBMiss: kib, markj.
Apr 18 2020, 11:14 PM · MIPS

Sep 4 2019

ray added a member for MIPS: ray.
Sep 4 2019, 9:05 PM

Mar 16 2019

jmallett abandoned D19172: Remove 32-bit SWARM kernels and supporting code..
Mar 16 2019, 6:15 AM · MIPS

Feb 12 2019

jmallett created D19172: Remove 32-bit SWARM kernels and supporting code..
Feb 12 2019, 9:59 PM · MIPS

Dec 22 2017

kib closed D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 11:27 PM · MIPS
jhb accepted D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 11:07 PM · MIPS
kib updated the diff for D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..

Remove mips 32bit atomic_load/store_64.

Dec 22 2017, 9:58 PM · MIPS
imp added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
In D13586#284245, @jhb wrote:

Yes, let's kill these and fix DDB instead.

Dec 22 2017, 8:44 PM · MIPS
jhb added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..

Yes, let's kill these and fix DDB instead.

Dec 22 2017, 8:40 PM · MIPS
kib added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
In D13586#284229, @jhb wrote:

BTW, I looked and the only place atomic_load_64 and atomic_store_64 are used in sys/mips is for DDB (db_read_bytes and db_write_bytes in sys/mips/mips/db_interface.c). It is not clear to me that this actually needs to be near this fancy. Most architectures just do a simple byte loop. Only 32-bit arm, mips, and powerpc attempt to handle accesses for exact word-size specially. arm doesn't try to handle 64-bit accesses with this kind of magic. powerpc just uses a 'uint64_t' load and store via C the same as it does for other word sizes. I suspect the db_read/write_bytes can just be simplified to match what powerpc does and and use simple C load/store and then these functions can be removed.

Dec 22 2017, 6:28 PM · MIPS
jhb added a comment to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..

BTW, I looked and the only place atomic_load_64 and atomic_store_64 are used in sys/mips is for DDB (db_read_bytes and db_write_bytes in sys/mips/mips/db_interface.c). It is not clear to me that this actually needs to be near this fancy. Most architectures just do a simple byte loop. Only 32-bit arm, mips, and powerpc attempt to handle accesses for exact word-size specially. arm doesn't try to handle 64-bit accesses with this kind of magic. powerpc just uses a 'uint64_t' load and store via C the same as it does for other word sizes. I suspect the db_read/write_bytes can just be simplified to match what powerpc does and and use simple C load/store and then these functions can be removed.

Dec 22 2017, 6:14 PM · MIPS
kib added inline comments to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 5:39 PM · MIPS
kib added inline comments to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 4:46 PM · MIPS
imp added inline comments to D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 4:22 PM · MIPS
kib updated the summary of D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 3:29 PM · MIPS
kib created D13586: Adapt assembler implementations of atomic_load_64() and atomic_store_64() on o32 mips to new calling conventions..
Dec 22 2017, 3:19 PM · MIPS

Nov 22 2017

brooks added a member for MIPS: brooks.
Nov 22 2017, 4:28 PM

Nov 19 2017

br added a member for MIPS: br.
Nov 19 2017, 5:12 PM

Oct 26 2017

landonf accepted D12737: [mips/broadcom] set sysctl "hw.model" by SoC ChipCommon ID.
Oct 26 2017, 6:51 PM · MIPS

Oct 21 2017

mizhka added inline comments to D12737: [mips/broadcom] set sysctl "hw.model" by SoC ChipCommon ID.
Oct 21 2017, 9:21 PM · MIPS
landonf added inline comments to D12737: [mips/broadcom] set sysctl "hw.model" by SoC ChipCommon ID.
Oct 21 2017, 7:43 PM · MIPS
mizhka added inline comments to D12737: [mips/broadcom] set sysctl "hw.model" by SoC ChipCommon ID.
Oct 21 2017, 7:27 PM · MIPS
landonf requested changes to D12737: [mips/broadcom] set sysctl "hw.model" by SoC ChipCommon ID.
Oct 21 2017, 7:10 PM · MIPS
yamori813_yahoo.co.jp accepted D12737: [mips/broadcom] set sysctl "hw.model" by SoC ChipCommon ID.
Oct 21 2017, 11:41 AM · MIPS

Oct 20 2017

mizhka created D12737: [mips/broadcom] set sysctl "hw.model" by SoC ChipCommon ID.
Oct 20 2017, 7:28 AM · MIPS

Aug 10 2017

arichardson added a member for MIPS: arichardson.
Aug 10 2017, 9:14 AM

May 17 2017

jhb added inline comments to D2535: New, experimental PMAP implementation for MIPS64.
May 17 2017, 5:23 PM · MIPS

Jan 17 2017

manu added a member for MIPS: manu.
Jan 17 2017, 10:02 AM

Dec 29 2016

jmcneill closed D8960: jz4780 AIC allow selecting internal/external codec at runtime by committing rS310776: The JZ4780 I2S can feed either the internal audio codec or the HDMI.
Dec 29 2016, 2:00 PM · MIPS
br accepted D8960: jz4780 AIC allow selecting internal/external codec at runtime.

looks good and useful. thanks!

Dec 29 2016, 1:12 PM · MIPS
jmcneill retitled D8960: jz4780 AIC allow selecting internal/external codec at runtime from to jz4780 AIC allow selecting internal/external codec at runtime.
Dec 29 2016, 12:43 AM · MIPS

Dec 23 2016

kan added a member for MIPS: kan.
Dec 23 2016, 10:24 PM

Dec 20 2016

jmcneill closed D8827: jz4780 LCD controller driver by committing rS310308: Add support for Ingenic JZ4780 LCD controller and enable framebuffer.
Dec 20 2016, 1:51 AM · MIPS
jmcneill closed D8784: jz4780: fix clk_gen divider calculation and rounding by committing rS310307: Choose the closes matching divider instead of one that results in a.
Dec 20 2016, 1:37 AM · MIPS

Dec 18 2016

kan accepted D8827: jz4780 LCD controller driver.

thanks

Dec 18 2016, 1:42 AM · MIPS

Dec 17 2016

jmcneill updated the diff for D8827: jz4780 LCD controller driver.

Cleanup on error path during attach.

Dec 17 2016, 10:34 PM · MIPS
kan accepted D8827: jz4780 LCD controller driver.
Dec 17 2016, 9:47 PM · MIPS
kan accepted D8784: jz4780: fix clk_gen divider calculation and rounding.
Dec 17 2016, 9:29 PM · MIPS
br added a comment to D8784: jz4780: fix clk_gen divider calculation and rounding.

I just can say that I saw some problem in that area configuring MMC device for X1000 processor a month ago and was thinking about similar change.

Dec 17 2016, 5:06 PM · MIPS
jmcneill retitled D8827: jz4780 LCD controller driver from to jz4780 LCD controller driver.
Dec 17 2016, 2:00 PM · MIPS

Dec 16 2016

jmcneill closed D8793: jz4780: add driver for SMB controller by committing rS310172: Add support for Ingenic JZ4780 SMBus controller..
Dec 16 2016, 8:05 PM · MIPS

Dec 15 2016

kan accepted D8793: jz4780: add driver for SMB controller.
Dec 15 2016, 4:37 PM · MIPS

Dec 14 2016

jmcneill updated the diff for D8793: jz4780: add driver for SMB controller.
  • Remove unused parameters in jzsmb_reset_locked
  • Replace timeval usage with timespec
Dec 14 2016, 10:47 PM · MIPS
jmcneill added inline comments to D8793: jz4780: add driver for SMB controller.
Dec 14 2016, 4:11 PM · MIPS
kan added inline comments to D8793: jz4780: add driver for SMB controller.
Dec 14 2016, 3:06 PM · MIPS
jmcneill retitled D8793: jz4780: add driver for SMB controller from to jz4780: add driver for SMB controller.
Dec 14 2016, 11:18 AM · MIPS
jmcneill retitled D8784: jz4780: fix clk_gen divider calculation and rounding from to jz4780: fix clk_gen divider calculation and rounding.
Dec 14 2016, 1:49 AM · MIPS

Sep 20 2016

adrian accepted D5623: Fix MIPS pmap_align_superpage() function to use superpage rather than segment alignment.

looks good then!

Sep 20 2016, 4:12 PM · MIPS

Sep 16 2016

jmallett added inline comments to D2535: New, experimental PMAP implementation for MIPS64.
Sep 16 2016, 11:57 PM · MIPS
brooks added inline comments to D2535: New, experimental PMAP implementation for MIPS64.
Sep 16 2016, 11:35 PM · MIPS
sbruno added a comment to D2535: New, experimental PMAP implementation for MIPS64.

Seems this patch is a lot more "clang friendly" as the MIPS64 clang compiled kernel can now at least *get* to trying to start init:

Sep 16 2016, 11:09 PM · MIPS
sson added a comment to D2535: New, experimental PMAP implementation for MIPS64.

I committed the pagemask enumeration/printing logic to -head a while ago. We should gather some dmesg's from various embedded MIPS boards.

IIRC, some of the mips24kc parts were only doing 4k pages.. :(

Sep 16 2016, 10:24 PM · MIPS
adrian added a comment to D2535: New, experimental PMAP implementation for MIPS64.

I committed the pagemask enumeration/printing logic to -head a while ago. We should gather some dmesg's from various embedded MIPS boards.

Sep 16 2016, 9:51 PM · MIPS
jmallett added inline comments to D2535: New, experimental PMAP implementation for MIPS64.
Sep 16 2016, 8:41 PM · MIPS
sbruno updated subscribers of D2535: New, experimental PMAP implementation for MIPS64.
Sep 16 2016, 8:34 PM · MIPS
sbruno updated subscribers of D2535: New, experimental PMAP implementation for MIPS64.
Sep 16 2016, 8:21 PM · MIPS
sbruno updated the diff for D2535: New, experimental PMAP implementation for MIPS64.

Copy/paste a couple of quick functions from pmap.c to pmap_mips64.c
and now the new option compiles and boots under MALTA64

Sep 16 2016, 7:53 PM · MIPS
sbruno updated the diff for D2535: New, experimental PMAP implementation for MIPS64.

Fix mips32 build.

Sep 16 2016, 7:16 PM · MIPS
sbruno updated the diff for D2535: New, experimental PMAP implementation for MIPS64.

Pull in CHERI change to fix compile time errors. Update and compile
tested world/kernel via mips64 target and MALTA64 under qemu.

Sep 16 2016, 7:03 PM · MIPS
sbruno added a comment to D2535: New, experimental PMAP implementation for MIPS64.

Ah, I need to steal from a Brooks commit over in CHERI:

Sep 16 2016, 6:15 PM · MIPS
sbruno added a comment to D2535: New, experimental PMAP implementation for MIPS64.

Currently fails to buildworld due to changes to pte.h:

Sep 16 2016, 6:02 PM · MIPS
sbruno updated the diff for D2535: New, experimental PMAP implementation for MIPS64.

Update review to head.

Sep 16 2016, 6:01 PM · MIPS