Differential D8793

jz4780: add driver for SMB controller
ClosedPublic
Actions

Authored by jmcneill on Dec 14 2016, 11:18 AM.

Tags

Referenced Files

	F148265207: D8793.id22909.diff
	Mon, Mar 16, 9:24 PM

	Unknown Object (File)
	Mon, Mar 9, 10:32 AM

	Unknown Object (File)
	Wed, Mar 4, 2:32 AM

	Unknown Object (File)
	Tue, Mar 3, 1:57 PM

	Unknown Object (File)
	Mon, Mar 2, 7:32 AM

	Unknown Object (File)
	Sun, Mar 1, 4:22 AM

	Unknown Object (File)
	Fri, Feb 27, 4:07 AM

	Unknown Object (File)
	Sat, Feb 21, 11:36 PM

Subscribers

Details

Reviewers

Group Reviewers

Commits

rS310172: Add support for Ingenic JZ4780 SMBus controller.

Summary

This patch adds support for the JZ4780 SMB controller.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jmcneill updated this revision to Diff 22909.Dec 14 2016, 11:18 AM

jmcneill retitled this revision from to jz4780: add driver for SMB controller.

jmcneill updated this object.

jmcneill edited the test plan for this revision. (Show Details)

jmcneill added reviewers: kan, MIPS.

jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.

jmcneill added a project: MIPS.

Herald added a subscriber: imp. · View Herald TranscriptDec 14 2016, 11:18 AM

kan added inline comments.Dec 14 2016, 3:06 PM

sys/mips/ingenic/jz4780_smb.c
142 ↗	(On Diff #22909)	oldaddr is unused?
248 ↗	(On Diff #22909)	timevalsub ? Or use timespec/getnanouptime and use timespecsub macro instead of rolling own?
360 ↗	(On Diff #22909)	Do thins only on error?

jmcneill added inline comments.Dec 14 2016, 4:11 PM

sys/mips/ingenic/jz4780_smb.c
142 ↗	(On Diff #22909)	Mirrored signature from jzsmb_reset, I will remove it.
248 ↗	(On Diff #22909)	Is there a tstohz somewhere? I couldn't find one.
360 ↗	(On Diff #22909)	Clearing the stop-hold bit causes the controller to send an I2C STOP condition. We need this in the success path too. It's a (harmless) noop only when we are performing 0-byte transfers.

Remove unused parameters in jzsmb_reset_locked
Replace timeval usage with timespec

jmcneill marked 6 inline comments as done.Dec 14 2016, 10:47 PM

kan accepted this revision.Dec 15 2016, 4:37 PM

kan edited edge metadata.

This revision is now accepted and ready to land.Dec 15 2016, 4:37 PM

Closed by commit rS310172: Add support for Ingenic JZ4780 SMBus controller. (authored by jmcneill). · Explain WhyDec 16 2016, 8:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

mips/

conf/

3 lines

ingenic/

1 line

98 lines

480 lines

Diff 23012

head/sys/mips/conf/JZ4780

Loading...

head/sys/mips/ingenic/files.jz4780

Loading...

head/sys/mips/ingenic/jz4780_smb.h

Loading...

head/sys/mips/ingenic/jz4780_smb.c

Loading...