Page MenuHomeFreeBSD

jz4780: add driver for SMB controller
ClosedPublic

Authored by jmcneill on Dec 14 2016, 11:18 AM.

Details

Summary

This patch adds support for the JZ4780 SMB controller.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmcneill updated this revision to Diff 22909.Dec 14 2016, 11:18 AM
jmcneill retitled this revision from to jz4780: add driver for SMB controller.
jmcneill updated this object.
jmcneill edited the test plan for this revision. (Show Details)
jmcneill added reviewers: kan, MIPS.
jmcneill set the repository for this revision to rS FreeBSD src repository.
jmcneill added a project: MIPS.
kan added inline comments.Dec 14 2016, 3:06 PM
sys/mips/ingenic/jz4780_smb.c
142 ↗(On Diff #22909)

oldaddr is unused?

248 ↗(On Diff #22909)

timevalsub ? Or use timespec/getnanouptime and use timespecsub macro instead of rolling own?

360 ↗(On Diff #22909)

Do thins only on error?

jmcneill added inline comments.Dec 14 2016, 4:11 PM
sys/mips/ingenic/jz4780_smb.c
142 ↗(On Diff #22909)

Mirrored signature from jzsmb_reset, I will remove it.

248 ↗(On Diff #22909)

Is there a tstohz somewhere? I couldn't find one.

360 ↗(On Diff #22909)

Clearing the stop-hold bit causes the controller to send an I2C STOP condition. We need this in the success path too. It's a (harmless) noop only when we are performing 0-byte transfers.

jmcneill updated this revision to Diff 22932.Dec 14 2016, 10:47 PM
  • Remove unused parameters in jzsmb_reset_locked
  • Replace timeval usage with timespec
jmcneill marked 6 inline comments as done.Dec 14 2016, 10:47 PM
kan accepted this revision.Dec 15 2016, 4:37 PM
kan edited edge metadata.
This revision is now accepted and ready to land.Dec 15 2016, 4:37 PM
This revision was automatically updated to reflect the committed changes.