Page MenuHomeFreeBSD

jmallett (Juli Mallett)
User

Projects

User Details

User Since
Oct 13 2015, 11:36 PM (192 w, 5 d)

Recent Activity

Sun, May 26

jmallett added a comment to D18593: mips32: move support for temporary mappings above KSEG0 to per-CPU data.
In D18593#440643, @jah wrote:

To answer my own question: no, we can't repurpose entry 0. We wire it down in switch.S to guarantee we won't take TLB faults on access to the kernel stack. Makes sense, esp. if we don't have something like a boot stack or exception stack to fall back on.

Sun, May 26, 3:20 PM

May 25 2019

jmallett added a comment to D18593: mips32: move support for temporary mappings above KSEG0 to per-CPU data.

I don't have any exceptionally helpful comments; the code looks fine, but I haven't given it the review it deserves.

May 25 2019, 4:15 PM

Mar 16 2019

jmallett abandoned D19172: Remove 32-bit SWARM kernels and supporting code..
Mar 16 2019, 6:15 AM · MIPS
jmallett committed rS345222: Remove empty directory left by r342255..
Remove empty directory left by r342255.
Mar 16 2019, 6:12 AM
jmallett committed rS345221: Remove obsolete wrappers for 64-bit loads/stores which were only used by the.
Remove obsolete wrappers for 64-bit loads/stores which were only used by the
Mar 16 2019, 6:10 AM

Feb 12 2019

jmallett created D19172: Remove 32-bit SWARM kernels and supporting code..
Feb 12 2019, 9:59 PM · MIPS

Aug 23 2018

jmallett added a comment to D16852: Update pfctl(8) tbrsize heuristic for high bandwidth interfaces.

To avoid that, the bucket needs to be sized such that the bucket depth divided by the average packet size through such a burst dequeue is less than the number of slots in the hardware ring. Even though we could with some work (less now that iflib is around) know the hardware ring size (and then assume it is stationary), I don't think in general 'average packet size over a burst dequeue' can be considered to be a stationary parameter, so I don't think we can come up with a formula that dials this in much better.

Aug 23 2018, 6:02 AM

Aug 22 2018

jmallett accepted D16852: Update pfctl(8) tbrsize heuristic for high bandwidth interfaces.

This seems straightforward, reasonable, and sufficient. Longer-term, I'd wonder about some sort of arithmetic approach here rather than this kind of hand-scaling?

Aug 22 2018, 9:01 PM

Aug 20 2018

jmallett accepted D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.

Fixes from first round appear complete.

Aug 20 2018, 7:14 PM

Aug 18 2018

jmallett accepted D16782: Fix 32-bit queue bandwidth limitation in pf and in the ALTQ token bucket regulator and HFSC scheduler.
Aug 18 2018, 3:59 PM

Jul 25 2018

jmallett accepted D16433: Add ALTQ support to iflib.
Jul 25 2018, 3:06 AM

Apr 16 2018

jmallett accepted D15108: Remove unused implementations of copyoutstr..

Did we come by that as a NetBSDism? Looks good to me.

Apr 16 2018, 10:06 PM

Apr 15 2018

jmallett accepted D15078: Remove unused badaddr() function..

Please destroy it, and while there double-check usedness of various other support.S functions if you haven't already. The amount of cruft has steadily fallen throughout the port, and the odds of unused things is probably higher than when I last did a pass. Thank you so much!

Apr 15 2018, 10:23 PM

Mar 28 2018

jmallett accepted D14875: Remove infrastructure for token-ring networks..
Mar 28 2018, 1:49 AM

Mar 7 2018

jmallett accepted D14603: MIPS: Implement fue*word* and casueword* in assembly..
Mar 7 2018, 7:18 PM

Feb 3 2018

jmallett accepted D14179: Fix makecontext() on MIPS O32..

I take full blame, and acknowledge spending too much time in code with -G0, and thus being somewhat lazy about gp's treatment.

Feb 3 2018, 1:11 AM

Jan 31 2018

jmallett accepted D13875: Switch to 16-byte stack alignment on N32 and N64..

Strong approve; this is a great improvement. Thank you!

Jan 31 2018, 12:23 AM

Jan 30 2018

jmallett added a comment to D13875: Switch to 16-byte stack alignment on N32 and N64..

I'd concur, and I had already pared down from NetBSD some in what's in that file when fixing various ABIs, IIRC, and I think it's reasonable to remove other things that are wrong or misleading.

Jan 30 2018, 6:50 PM

Jan 24 2018

jmallett accepted D13875: Switch to 16-byte stack alignment on N32 and N64..
In D13875#292023, @jhb wrote:

I'm not quite sure what you would like to do for makecontext. It is already using the right value (16 for newabi), but I don't know if it's really safe to expose STACK_ALIGN to userland (perhaps I can include <machine/md_var.h> to get it in this file?)

Jan 24 2018, 9:47 PM

Jan 12 2018

jmallett added a comment to D13875: Switch to 16-byte stack alignment on N32 and N64..

Also, lib/libc/mips/gen/makecontext.c uses its own constants, and should likely be pulled out of the conditional, after subtracting enough registers' worth o' room.

Jan 12 2018, 12:38 AM

Jan 11 2018

jmallett added a comment to D13875: Switch to 16-byte stack alignment on N32 and N64..

Also fix alignment in cpu_set_upcall in vm_machdep.c?

Jan 11 2018, 11:22 PM

Jan 10 2018

jmallett accepted D13830: Set the 'FR' bit in the status register for N32 kernels..

This seems acceptable and correct within what's currently present. I feel like a unified macro for these sets of flags is really needed, to simplify the code and ensure consistency in checks, but as an incremental improvement this looks good. Thanks!

Jan 10 2018, 7:47 PM

Apr 4 2017

jmallett accepted D10086: Add a weak alias from ffs() to __ffssi2() to pacify modern GCC..

Awesome, thank you for implementing it in the right place! And we're confident this doesn't produce any referential loops, right? Where builtin_ctz would generate a call to ffssi2?

Apr 4 2017, 2:05 AM

Mar 21 2017

jmallett added a comment to D10086: Add a weak alias from ffs() to __ffssi2() to pacify modern GCC..

This looks reasonable, but I share the confusion about correctness. It seems like this should be in libgcc generally. I know we spoke about this, but I've forgotten; can you remind me why libgcc isn't providing this symbol?

Mar 21 2017, 10:47 PM

Feb 9 2017

jmallett added a comment to D5017: More than 65K connection from single application.

I think that "collision" is ok.
Of course it IS a new behaviour, but that is what we are trying to get. new behaviour.

Feb 9 2017, 5:50 PM · network

Jan 20 2017

jmallett added a comment to D5017: More than 65K connection from single application.

Added @pkelsey as a reviewer because I didn't realize it would *assign* to him, and rather wanted to invite his comments. Given the work he's done on promiscuous sockets, with a fairly widely-deployed codebase, I think his insights would be meaningful on these changes. The principle seems about right to me here, but I'm not sure about some of the specifics.

Jan 20 2017, 4:45 PM · network
jmallett added a reviewer for D5017: More than 65K connection from single application: pkelsey.
Jan 20 2017, 4:43 PM · network

Jan 6 2017

jmallett accepted D9032: Enable /usr/lib32 for o32 binaries on mips64..
Jan 6 2017, 8:07 PM

Jan 4 2017

jmallett added inline comments to D9032: Enable /usr/lib32 for o32 binaries on mips64..
Jan 4 2017, 8:55 PM
jmallett added inline comments to D9032: Enable /usr/lib32 for o32 binaries on mips64..
Jan 4 2017, 5:59 PM
jmallett accepted D9032: Enable /usr/lib32 for o32 binaries on mips64..

This looks good to me, though it'd be nice to see the default ISA thing resolved or confirmed. I also do favour collapsing the target emulation stuff more as possible, but it's not worth holding this up.

Jan 4 2017, 3:46 AM

Nov 28 2016

jmallett accepted D8666: Fix packaging for clang, lldb and lld 3.9.0.
Nov 28 2016, 8:11 PM

Oct 11 2016

jmallett added inline comments to D5603: ASLR.
Oct 11 2016, 5:16 PM

Sep 16 2016

jmallett added inline comments to D2535: New, experimental PMAP implementation for MIPS64.
Sep 16 2016, 11:57 PM · MIPS
jmallett added inline comments to D2535: New, experimental PMAP implementation for MIPS64.
Sep 16 2016, 8:41 PM · MIPS

May 29 2016

jmallett accepted D6561: Add and correct MIPS relocation types.
May 29 2016, 4:55 AM

Jan 29 2016

jmallett accepted D5123: Add a SYSDECODE_ABI_ prefix to the ABI enums to avoid potential collisions..
Jan 29 2016, 9:06 PM

Jan 14 2016

jmallett committed rS294047: Make it possible to specify the path to userboot.so with the -b flag..
Make it possible to specify the path to userboot.so with the -b flag.
Jan 14 2016, 10:08 PM

Oct 13 2015

jmallett added a comment to V6: Should /usr/local be included in FreeBSD's toolchain paths?.

I've done this for years in a proprietary product based on FreeBSD and can't imagine going back. The ill effects are few and mostly easy to diagnose, being only about as strange as the things you encounter when you're pretty sure /usr/local is in the search path, but it turns out that it isn't for obscure reasons. Or when badly-behaved configure scripts, etc., won't let you add it. While I sort of morn the loss of more strange BSD conservatism, this is such an obvious reality that I cannot possibly bring myself to tolerate the idea that we should keep going. Users should not have to care about how things were in the mid '90s. An increasing number of them weren't even born yet. System compilers search the default location of local additions and packages.

Oct 13 2015, 11:46 PM