Page MenuHomeFreeBSD

Fix makecontext() on MIPS O32.
ClosedPublic

Authored by jhb on Feb 2 2018, 10:51 PM.
Tags
None
Referenced Files
F165048477: D14179.id38800.diff
Wed, Aug 5, 1:37 PM
Unknown Object (File)
Sun, Aug 2, 3:02 AM
Unknown Object (File)
Sat, Aug 1, 8:01 AM
Unknown Object (File)
Thu, Jul 30, 11:49 PM
Unknown Object (File)
Thu, Jul 30, 4:02 PM
Unknown Object (File)
Tue, Jul 28, 11:49 AM
Unknown Object (File)
Wed, Jul 22, 12:14 PM
Unknown Object (File)
Tue, Jul 21, 11:55 AM
Subscribers

Details

Summary

The GP register can be clobbered by the callback, so save it in S1 while
invoking the callback function.

Test Plan
  • the various makecontext tests now pass on o32 instead of core dumping when trying to call ctx_done due to a trashed GP.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I take full blame, and acknowledge spending too much time in code with -G0, and thus being somewhat lazy about gp's treatment.

I'd say that because there are a bunch of different ABI semantics here, the comment could be modified to be more explicit about s1 being callee-saved in o32, while gp is callee-saved in n32 and n64, or something.

Thank you! It's good as-is, or with a comment which is more explicit about register saving responsibility.

This revision is now accepted and ready to land.Feb 3 2018, 1:11 AM
This revision was automatically updated to reflect the committed changes.