Page MenuHomeFreeBSD

Fix makecontext() on MIPS O32.
ClosedPublic

Authored by jhb on Feb 2 2018, 10:51 PM.
Tags
None
Referenced Files
F154263354: D14179.id38800.diff
Mon, Apr 27, 11:39 AM
Unknown Object (File)
Thu, Apr 23, 12:19 PM
Unknown Object (File)
Thu, Apr 23, 4:20 AM
Unknown Object (File)
Thu, Apr 23, 1:10 AM
Unknown Object (File)
Mon, Apr 20, 8:00 PM
Unknown Object (File)
Mon, Apr 6, 5:28 PM
Unknown Object (File)
Sun, Apr 5, 3:25 PM
Unknown Object (File)
Thu, Apr 2, 4:20 AM
Subscribers

Details

Summary

The GP register can be clobbered by the callback, so save it in S1 while
invoking the callback function.

Test Plan
  • the various makecontext tests now pass on o32 instead of core dumping when trying to call ctx_done due to a trashed GP.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

I take full blame, and acknowledge spending too much time in code with -G0, and thus being somewhat lazy about gp's treatment.

I'd say that because there are a bunch of different ABI semantics here, the comment could be modified to be more explicit about s1 being callee-saved in o32, while gp is callee-saved in n32 and n64, or something.

Thank you! It's good as-is, or with a comment which is more explicit about register saving responsibility.

This revision is now accepted and ready to land.Feb 3 2018, 1:11 AM
This revision was automatically updated to reflect the committed changes.