Page MenuHomeFreeBSD

jz4780 LCD controller driver
ClosedPublic

Authored by jmcneill on Dec 17 2016, 2:00 PM.

Details

Summary

This patch adds support for the LCD controller in JZ4780. This (along with dependent changes) gives HDMI frame buffer console support on CI20.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jmcneill updated this revision to Diff 23029.Dec 17 2016, 2:00 PM
jmcneill retitled this revision from to jz4780 LCD controller driver.
jmcneill updated this object.
jmcneill edited the test plan for this revision. (Show Details)
jmcneill added reviewers: kan, br, MIPS.
jmcneill set the repository for this revision to rS FreeBSD src repository.
jmcneill added a project: MIPS.
kan accepted this revision.Dec 17 2016, 9:47 PM
kan edited edge metadata.
kan added inline comments.
sys/mips/ingenic/jz4780_lcd.c
468 ↗(On Diff #23029)

This function leaks everything on failure. We not expect it to fail, ever?

This revision is now accepted and ready to land.Dec 17 2016, 9:47 PM
jmcneill updated this revision to Diff 23040.Dec 17 2016, 10:34 PM
jmcneill edited edge metadata.

Cleanup on error path during attach.

This revision now requires review to proceed.Dec 17 2016, 10:34 PM
jmcneill marked an inline comment as done.Dec 17 2016, 10:34 PM
kan accepted this revision.Dec 18 2016, 1:42 AM
kan edited edge metadata.

thanks

This revision is now accepted and ready to land.Dec 18 2016, 1:42 AM
This revision was automatically updated to reflect the committed changes.