Differential D8826

Split dwc_hdmi core code out from imx6_hdmi
ClosedPublic
Actions

Authored by jmcneill on Dec 17 2016, 1:48 PM.

Details

Reviewers

gonzo

Group Reviewers

ARM

Commits

rS310306: Split the DesignWare HDMI-specific code from imx6_hdmi.c into a separate

Summary

This patch splits out the DesignWare HDMI-specific code from imx6_hdmi.c into a separate file and adds a generic DT binding that takes advantage of the extres framework for setting up clocks.

Test Plan

I tested the generic binding on JZ4780 (CI20), but still needs to be tested on i.MX6.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jmcneill updated this revision to Diff 23028.Dec 17 2016, 1:48 PM

jmcneill retitled this revision from to Split dwc_hdmi core code out from imx6_hdmi.

jmcneill updated this object.

jmcneill edited the test plan for this revision. (Show Details)

jmcneill added reviewers: ARM, gonzo.

jmcneill set the repository for this revision to rS FreeBSD src repository - subversion.

jmcneill added a project: ARM.

Herald added subscribers: andrew, imp. · View Herald TranscriptDec 17 2016, 1:48 PM

jmcneill added a child revision: D8827: jz4780 LCD controller driver.Dec 17 2016, 2:00 PM

mmel added a subscriber: mmel.Dec 17 2016, 3:38 PM

mmel added inline comments.

sys/dev/hdmi/dwc_hdmi_fdt.c
200 ↗	(On Diff #23028)	This breaks generic kernel. We cannot have multiple modules with same name (a first argument) within single kernel. This is also reason, why using generic name for specific driver is not a best option. The driver name is not related/linked to anything, but DRIVER_DEPEND(). So you can simply change name without any negative effects.