User Details
- User Since
- Mar 4 2020, 12:25 PM (186 w, 4 d)
Mar 12 2021
Jan 11 2021
This review was approved in March last year. It seems all issues have been solved. Could anyone commit this?
Nov 5 2020
I will close this review because the D26885 does the same thing in a cleaner way.
Oct 29 2020
Sep 3 2020
Jul 23 2020
Grammar correction suggestions in code comments.
Jul 22 2020
'if _BYTE_ORDER' removed, making the code more generic, as suggested in the comments of this revision. Comments were also added explaining why endian conversion is necessary.
Jul 20 2020
@arichardson Which freebsd .img revision are you using?
Jul 8 2020
In this way the specificity of the mips is removed, the adjustments of the bus_space in the vtpci_* defines makes the code more generic.
Jun 24 2020
Jun 23 2020
Jun 10 2020
@arichardson Could you say what is the complete command you use to run this vm on qemu? (./qemu-system-mips64 -M malta (...) what else?)
I reversed this commit and compiled the kernel and would like to test it according to your environment.
Mar 25 2020
Following recommendation, removing unnecessary parentheses.
Mar 24 2020
Following @melifaro `s recommendations, type of variable changed to int, instead of unsigned int.