Page MenuHomeFreeBSD

Fix bad libbxo format strings in jls
ClosedPublic

Authored by arichardson on Oct 21 2020, 11:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Oct 2 2024, 3:42 AM
Unknown Object (File)
Sep 27 2024, 8:11 AM
Unknown Object (File)
Sep 24 2024, 6:45 AM
Unknown Object (File)
Sep 23 2024, 3:44 PM
Unknown Object (File)
Sep 23 2024, 6:22 AM
Unknown Object (File)
Sep 23 2024, 5:48 AM
Unknown Object (File)
Sep 22 2024, 11:10 AM
Unknown Object (File)
Sep 22 2024, 7:28 AM
Subscribers

Details

Summary

The existing format string for the empty case was trying to read varargs
values that weren't passed to xo_emit. This appears to work on x86 (since
the next argument is probably a pointer an empty string), but for CHERI
we can bound variadic arguments and detect a read past the end.

While touching these lines also use the libxo a modifier to avoid having to
construct the libxo format string using asprintf.

Found by: CHERI

Test Plan

crashes on CHERI-MIPS before, now prints the expected values (XML and Text)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable