Page MenuHomeFreeBSD

Fix bad libbxo format strings in jls
ClosedPublic

Authored by arichardson on Oct 21 2020, 11:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jul 29, 11:15 PM
Unknown Object (File)
Mon, Jul 28, 9:55 PM
Unknown Object (File)
Sun, Jul 27, 3:57 PM
Unknown Object (File)
Sun, Jul 27, 3:54 PM
Unknown Object (File)
Sun, Jul 27, 6:14 AM
Unknown Object (File)
Mon, Jul 21, 8:49 AM
Unknown Object (File)
Fri, Jul 18, 12:09 PM
Unknown Object (File)
Fri, Jul 18, 11:39 AM
Subscribers

Details

Summary

The existing format string for the empty case was trying to read varargs
values that weren't passed to xo_emit. This appears to work on x86 (since
the next argument is probably a pointer an empty string), but for CHERI
we can bound variadic arguments and detect a read past the end.

While touching these lines also use the libxo a modifier to avoid having to
construct the libxo format string using asprintf.

Found by: CHERI

Test Plan

crashes on CHERI-MIPS before, now prints the expected values (XML and Text)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable