Page MenuHomeFreeBSD

Fix bad libbxo format strings in jls
ClosedPublic

Authored by arichardson on Oct 21 2020, 11:18 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Dec 7, 7:45 PM
Unknown Object (File)
Wed, Dec 3, 11:26 PM
Unknown Object (File)
Wed, Dec 3, 6:13 PM
Unknown Object (File)
Mon, Dec 1, 10:20 AM
Unknown Object (File)
Mon, Dec 1, 5:45 AM
Unknown Object (File)
Sat, Nov 29, 8:04 PM
Unknown Object (File)
Sat, Nov 29, 12:20 PM
Unknown Object (File)
Sat, Nov 29, 12:09 AM
Subscribers

Details

Summary

The existing format string for the empty case was trying to read varargs
values that weren't passed to xo_emit. This appears to work on x86 (since
the next argument is probably a pointer an empty string), but for CHERI
we can bound variadic arguments and detect a read past the end.

While touching these lines also use the libxo a modifier to avoid having to
construct the libxo format string using asprintf.

Found by: CHERI

Test Plan

crashes on CHERI-MIPS before, now prints the expected values (XML and Text)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34293
Build 31430: arc lint + arc unit