Page MenuHomeFreeBSD

Fix bad libbxo format strings in jls
ClosedPublic

Authored by arichardson on Oct 21 2020, 11:18 AM.
Tags
None
Referenced Files
F138026940: D26885.id78539.diff
Fri, Nov 28, 7:29 AM
F137975650: D26885.id78539.diff
Thu, Nov 27, 8:07 PM
Unknown Object (File)
Thu, Nov 27, 10:42 AM
Unknown Object (File)
Wed, Nov 26, 10:50 PM
Unknown Object (File)
Tue, Nov 25, 11:42 PM
Unknown Object (File)
Tue, Nov 25, 10:24 PM
Unknown Object (File)
Tue, Nov 25, 3:03 PM
Unknown Object (File)
Tue, Nov 25, 7:37 AM
Subscribers

Details

Summary

The existing format string for the empty case was trying to read varargs
values that weren't passed to xo_emit. This appears to work on x86 (since
the next argument is probably a pointer an empty string), but for CHERI
we can bound variadic arguments and detect a read past the end.

While touching these lines also use the libxo a modifier to avoid having to
construct the libxo format string using asprintf.

Found by: CHERI

Test Plan

crashes on CHERI-MIPS before, now prints the expected values (XML and Text)

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34293
Build 31430: arc lint + arc unit