In D28738#643660, @rpokala wrote:

If the intention is to support smbios(4) on non-x86, shouldn't it be added to a non-x86 KERNCONF file?

Do we want to put this link and section reference in the commit message?

In D28749#643720, @manu wrote:

Any docs on what this should contain ?

In D28707#643461, @imp wrote:

We also have a machine here that won't boot with the patches applied. Please don't commit until that gets worked out....

Should https://reviews.freebsd.org/D28745 be squashed into this review?

It likely makes sense to squash this with https://reviews.freebsd.org/D28738

Ok, I think I've gotten a handle on the git-arc tool.

No, having only one loop that set both kenv is what we need.

In D28707#643366, @emaste wrote:

@allanjude these originated as a number of commits, right? Does it make sense to start committing earlier patches that have been reviewed (e.g. stand bits) and rebase this review?

In D28707#643382, @manu wrote:

In D28707#643380, @tsoome wrote:

In D28707#643373, @manu wrote:

stand patches can't go in without the kernel ones.
If we find a smbios v3 table we don't set the kenv of the v2.1 one so kernel won't work.

Ou, but that would be major pain - it would be bad day for anyone trying to boot older kernel... so we should provide both to let older kernel to work?

Yeah I think so, I think we should just export every smbios table in loader and let kernel choose.

Repost

• stand: Support (and prefer) the SMBIOS 64-bit Entry Point Structure
• smbios: Move smbios driver out from x86 machdep code
• smbios: Support (and prefer) the SMBIOS 64-bit Entry Point Structure
• smbios: Use loader provided adddress for SMBIOS entry point
• acpi: Add workaround for Altra I2C memory resource
• iicsmb: Request the bus recursively in bread()
• ipmi_smbios: Deduplicate smbios entry point discovery logic
• Enable smbios in ARM64 GENERIC
• ipmi: Add smbus and pci ipmi types to aarch64 build
• ig4(4): Add an EMAG device type
• ig4(4): Increase timeout to about 1 second
• ig4(4): Use calculated value when sda_hold is zero in ACPI
• ipmi_ssif: Fix inverted for the end of multi-part reads
• smbios: update makefile for new location of smbios.c
• ipmi: on aarch64, load dependancies to increase chance of finding ipmi device
• ipmi_smbios: remove unused smbios_cksum function
• [squashme] Address feedback from manu and andrew

In D28247#632482, @kp wrote:

I don't think it's a string length issue.

In D28247#632482, @kp wrote:

I don't think it's a string length issue. It's an issue of incorrect assumptions. This patch assumes that the original name of the interface is always the driver name ('if_dname') plus unit number. That's not the case for epair interfaces, and I wouldn't be surprised that this also fails for vlan interfaces (where the numeric suffix is not the unit number).

Committed as R10:b84d0aaa4e64

In D28247#632273, @kp wrote:

It turns out there's an edge case we didn't consider:

epair0a: flags=8842<BROADCAST,RUNNING,SIMPLEX,MULTICAST> metric 0 mtu 1500
        initname: epair0
        options=8<VLAN_MTU>
        ether 02:a5:17:a0:1e:0a
        groups: epair
        media: Ethernet 10Gbase-T (10Gbase-T <full-duplex>)
        status: active
        nd6 options=21<PERFORMNUD,AUTO_LINKLOCAL>

Also, this wants a test case or two.

Fix missing {

In D28247#632082, @kp wrote:

So this doesn't actually build for me:

...
--- all_subdir_rescue ---
/usr/src/sbin/ifconfig/ifconfig.c:1373:16: error: unused variable 'ifs' [-Werror,-Wunused-variable]
        struct ifstat ifs;
                      ^
/usr/src/sbin/ifconfig/ifconfig.c:1371:18: error: unused variable 'ift' [-Werror,-Wunused-variable]
        struct ifaddrs *ift;
                        ^
/usr/src/sbin/ifconfig/ifconfig.c:1438:2: error: expected identifier or '('
        if (ioctl(s, SIOCGIFCAP, (caddr_t)&ifr) == 0) {
        ^
/usr/src/sbin/ifconfig/ifconfig.c:1449:2: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
        tunnel_status(s);
        ^
/usr/src/sbin/ifconfig/ifconfig.c:1449:16: error: a parameter list without types is only allowed in a function definition
        tunnel_status(s);
                      ^
/usr/src/sbin/ifconfig/ifconfig.c:1451:2: error: expected identifier or '('
        for (ift = ifa; ift != NULL; ift = ift->ifa_next) {
        ^
/usr/src/sbin/ifconfig/ifconfig.c:1481:2: error: expected identifier or '('
        if (allfamilies)
        ^
/usr/src/sbin/ifconfig/ifconfig.c:1483:2: error: expected identifier or '('
        else if (afp->af_other_status != NULL)
        ^
/usr/src/sbin/ifconfig/ifconfig.c:1486:10: error: unknown type name 'ifs'
        strlcpy(ifs.ifs_name, name, sizeof ifs.ifs_name);
                ^
/usr/src/sbin/ifconfig/ifconfig.c:1486:13: error: expected ')'
        strlcpy(ifs.ifs_name, name, sizeof ifs.ifs_name);
                   ^
/usr/src/sbin/ifconfig/ifconfig.c:1486:9: note: to match this '('
        strlcpy(ifs.ifs_name, name, sizeof ifs.ifs_name);
               ^
/usr/src/sbin/ifconfig/ifconfig.c:1486:2: error: type specifier missing, defaults to 'int' [-Werror,-Wimplicit-int]
        strlcpy(ifs.ifs_name, name, sizeof ifs.ifs_name);
        ^
/usr/src/sbin/ifconfig/ifconfig.c:1487:2: error: expected identifier or '('
        if (ioctl(s, SIOCGIFSTATUS, &ifs) == 0)
        ^
...

It looks like ifconfig may be using the installed sockio.h header rather than the one from the source repo.

Fix logic reversal caught by kp

Reduce indentation

Remove the loop, the buffer wont be larger than IFNAMSIZ

Use strncmp

Update manpage wording with suggestions from rpokala

Thanks for taking care of this Drew.

Looks good to me. This will also accelerate AES-GCM by default on ARMv8 once D27454 lands

Looks good to me modulo Ed's comment on the sysctl description text

looks good

Update with more feedback from emaste and debdrup

In D27715#620124, @debdrup wrote:

Do I remember wrong, or does Zstd also offer the option to adaptively compress at as high a level as possible while maintaining bandwidth, or is that only for zfs send|receive? If so, should that also be mentioned?

Cleanup suggested by Pauamma

Remove double negative as suggested by emaste