Page MenuHomeFreeBSD

sysctl: implement debug.kdb.panic_str
ClosedPublic

Authored by imp on Jan 8 2021, 4:42 PM.

Details

Summary

This is just like debug.kdb.panic, except the string that's passed in
is reported in the panic message. This allows people with automated
systems to collect kernel panics over a large fleet of machines to
flag panics better. Strings like "Warner look at this hang" or "see
JIRA ABC-1234 for details" allow these automated systems to route the
forced panic to the appropriate engineers like you can with other
types of panics. Other users are likely possible.

Sponsored by: Netflix

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp requested review of this revision.Jan 8 2021, 4:42 PM
emaste added inline comments.
sys/kern/subr_kdb.c
115

panic the kernel with the provided string as the panic message?

222–227

confused by this part

remove cut and pasted code that was bogus

allanjude added a subscriber: allanjude.

Looks good to me modulo Ed's comment on the sysctl description text

This revision is now accepted and ready to land.Jan 8 2021, 5:54 PM
This revision now requires review to proceed.Jan 8 2021, 5:59 PM
lwhsu added inline comments.
share/man/man7/security.7
542

Don't forget to bump .Dd

This revision was not accepted when it landed; it landed in state Needs Review.Jan 8 2021, 9:31 PM
This revision was automatically updated to reflect the committed changes.