Apply suggested changes from jrm
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
May 1 2020
Apr 30 2020
This looks good to me. Although I wonder if we might not want a solution that also covers people who don't run the installer. So that things like the VM Images that are generated by the release have the certs setup
Apr 28 2020
Apr 27 2020
Apr 24 2020
With DESTDIR support in certctl now, this looks good to me
Apr 23 2020
Move copyright message to the correct place
Apr 14 2020
Not sure if ministat belongs on the list. It is more for doing statistical analysis, it doesn't actually give you any stats/status about your system
Apr 13 2020
Apr 12 2020
Fix typo
Address most of cem's feedback
In D24371#536111, @eugen_grosbein.net wrote:I'm not sure I understand the problem.
The candelete() function does properly detect if the disk supports TRIM
Does or does not? Anyway, it works for me just fine using stable/11 system:
mdconfig -at malloc -s 1m
md0
- diskinfo -v md0 | grep TRIM Yes # TRIM/UNMAP support
- trim -f /dev/md0; echo $?
trim /dev/md0 offset 0 length 1048576
0The function candelete() was copied from diskinfo(8) code as noted in the commit message. The diskinfo utility opens the device with O_RDONLY, too. It all was tested before committing.
In D24371#536107, @asomers wrote:The change LGTM, but double check your commit message. Is there a missing "not"?
Apr 11 2020
Update to fix some issues and catch up with HEAD
Apr 10 2020
Add VIRTIO_BLK_T_DISCARD (TRIM) support to the bhyve virtio-blk backend
Apr 3 2020
Mar 31 2020
Mar 30 2020
This seems like a good way to cut down the size
Mar 16 2020
Reviewed By: allanjude
Mar 12 2020
Mar 11 2020
ping: Is there anything left for Dave to do here, or can we commit this?
Is this stalled?
Mar 8 2020
Feb 22 2020
Jan 31 2020
Jan 28 2020
Jan 15 2020
Jan 14 2020
Reviewed by: allanjude
Jan 13 2020
Dec 12 2019
Dec 9 2019
Reviewed By: allanjude
Dec 4 2019
Nov 29 2019
Nov 28 2019
I wonder if it would make sense to try to stripe the trailing whitespace from the serial # etc. The json output looks a little silly:
Nov 27 2019
Nov 25 2019
Reviewed By: allanjude
Nov 22 2019
In D22193#488245, @trasz wrote:FWIW, grepping for that pattern only brings up the one hit Warner has already mentioned, and it's already under #ifdef illumos:
% grep -r '%ss%d' * cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c: (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice);
Nov 19 2019
Nov 15 2019
Nov 13 2019
I am fine with moving the text, just make sure you svn commit the correct files
Nov 12 2019
In D22304#487863, @markj wrote:Why don't we just have a "name" parameter that determines the entire gnop provider name?
it looks like you added conduct-reporting.html (the build artifact) not .xml (the source), and that it was not marked as a text file.
Nov 8 2019
Maybe give Warner a chance to provide any more feedback before we commit this.
Nov 7 2019
Attachment does seem to fit the bill best
Nov 1 2019
In D22193#485070, @imp wrote:/* * Fill in the devid, now that we've labeled the disk. */ (void) snprintf(buf, sizeof (buf), "%ss%d", path, slice); if ((fd = open(buf, O_RDONLY)) < 0) { (void) fprintf(stderr, gettext("cannot open '%s': %s\n"), buf, strerror(errno)); return (-1); }is one example, this one is from cddl/contrib/opensolaris/cmd/zpool/zpool_vdev.c
Oct 30 2019
Is the 'd' or 'c' in the description a typo? Should it be ada0d/s1? or ada0/s1
Oct 23 2019
Oct 11 2019
Reviewed By: allanjude
Oct 3 2019
Oct 2 2019
Sep 19 2019
Committed as rS352504
Sep 18 2019
Sep 14 2019
Approved By: allanjude
Sep 13 2019
Sep 6 2019
Reviewed By: allanjude
Aug 26 2019
Other than fixing the links, looks good to me.
Aug 22 2019
We should make the -M flag be compile time dependant in WITH_STATS
Aug 20 2019
Aug 14 2019
Aug 13 2019
Aug 8 2019
Thank you very much for making this work.
Aug 1 2019
Approved By: allanjude