Show HBA path in 'diskinfo -v'.

[trasz]

Summary

Add GEOM attribute to report physical device name, and report it
via 'diskinfo -v'. This avoids the need to track it down via CAM,
and should also work for disks that don't use CAM. And since it's
inherited over GEOM hierarchy, in most cases one doesn't need
to walk the GEOM graph either, eg you can use it on a partition
instead of disk itself.

[chuck]

Overall, the changes look good to me, but I am having a twinge over "HBA". HBA completely makes sense for SCSI but doesn't at all for NVMe. SATA falls in the middle depending on whether this is a proprietary thing or AHCI.

[trasz]

In D22249#486617, @chuck wrote:

Overall, the changes look good to me, but I am having a twinge over "HBA". HBA completely makes sense for SCSI but doesn't at all for NVMe. SATA falls in the middle depending on whether this is a proprietary thing or AHCI.

I have the same problem - the most factually correct way would be "newbus parent node", but that would be completely unparseable to most of the users.

Any thoughts on merging those two attributes into a single string? I've mimicked the fields from struct ccb_pathinq, but I'm not sure if that's the right thing to do.

[chuck]

In D22249#486852, @trasz wrote:

I have the same problem - the most factually correct way would be "newbus parent node", but that would be completely unparseable to most of the users.

Any thoughts on merging those two attributes into a single string? I've mimicked the fields from struct ccb_pathinq, but I'm not sure if that's the right thing to do.

I'm struggling with this as well. How does "Controller" or perhaps "Drive controller" strike you? With the end result being something like "Controller device name" or "Controller device path". Open to suggestions.

[imp]

In D22249#486854, @chuck wrote:

In D22249#486852, @trasz wrote:

I have the same problem - the most factually correct way would be "newbus parent node", but that would be completely unparseable to most of the users.

Any thoughts on merging those two attributes into a single string? I've mimicked the fields from struct ccb_pathinq, but I'm not sure if that's the right thing to do.

I'm struggling with this as well. How does "Controller" or perhaps "Drive controller" strike you? With the end result being something like "Controller device name" or "Controller device path". Open to suggestions.

"Attachment:" is closest to what this does. Still, this is of dubious value, so I didn't sweat the name too much given that we'll likely remove it when CAM becomes new-busified.

[allanjude]

Attachment does seem to fit the bill best

Reviewed by: allanjude

[trasz]

"Attachment" sounds perfect, thanks!

As of the value - even after newbusification, this should still be useful if inherited, eg over GPART or GELI.

[trasz]

Rename to "attachment", merge into a single GEOM attribute.

[allanjude]

Maybe give Warner a chance to provide any more feedback before we commit this.

[imp]

In D22249#487261, @allanjude wrote:

Maybe give Warner a chance to provide any more feedback before we commit this.

I'm cool with this as is. It fills a need, but one that I hope will have a short-term time horizon.