loader: remove libsa/crc32.c and use version from zlib

[tsoome]

Summary

we have crc32(const void *, size_t) in libsa. Unfortunately zlib has crc32(long, const unigned char *, unsigned) and we have conflict.

Since we do build libsa with zlib, we can use zlib version instead.

[tsoome]

missed stand/uboot/lib/glue.c

[cem]

I’d suggest using the zlib one unless it takes excessive space (bigger precomputed tables, for ex.).

[tsoome]

In D24068#529184, @cem wrote:

I’d suggest using the zlib one unless it takes excessive space (bigger precomputed tables, for ex.).

I did that in illumos:) I was not sure about the preferred way with freebsd; it is larger, but it is present anyhow because we do link zlib and it is referred.

[cem]

In D24068#529188, @tsoome wrote:

I did that in illumos:) I was not sure about the preferred way with freebsd; it is larger, but it is present anyhow because we do link zlib and it is referred.

Ah, if we already link zlib I see no reason to include a second copy.

[tsoome]

drop crc32 from libsa and use version provided by zlib.

[allanjude]

Reviewed By: allanjude