Page MenuHomeFreeBSD

Write packages directory to ${PKGREPOSITORY} rather than ${WRKDIR}/pkg
Needs ReviewPublic

Authored by allanjude on Apr 13 2020, 8:16 PM.
Tags
None
Referenced Files
F133611390: D24402.diff
Mon, Oct 27, 12:36 AM
Unknown Object (File)
Mon, Oct 20, 3:16 PM
Unknown Object (File)
Mon, Oct 20, 3:15 PM
Unknown Object (File)
Mon, Oct 20, 1:30 AM
Unknown Object (File)
Sat, Oct 18, 10:57 PM
Unknown Object (File)
Fri, Oct 17, 3:02 AM
Unknown Object (File)
Mon, Oct 13, 6:01 AM
Unknown Object (File)
Mon, Sep 29, 3:56 AM
Subscribers

Details

Reviewers
bdrewery
bapt
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Avoid copying each package from the wrkdir to the repository individually

This depends on a change to pkg to makes sure not to overwrite the pkg in the repository unless it completes creating the package without error

This unlocks pkg files being named with a hash of their content (unpredictable filename), which will allow use of a CDN for pkg downloads

Related changes to pkg: https://github.com/freebsd/pkg/pull/1829
Related changes to poudriere: https://github.com/freebsd/poudriere/pull/751

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 30471
Build 28226: arc lint + arc unit

Event Timeline

What happens when not actually building packages but simply installing a port, that is, when you don't have a PKGREPOSITORY?

I do not think this change is a good idea.

I tend to agree with @mat here, the point here is to respect one of the promise of the ports tree, everything is done as much as possible in workdir and only in last minute replicated to the filesystem