geli taste: allow GELIBOOT tagged providers as well
ClosedPublic
Actions

Authored by kevans on Jan 27 2020, 11:02 PM.

Details

Reviewers

allanjude
pjd
oshogbo

Commits

rS357665: geli taste: allow GELIBOOT tagged providers as well

Summary

Currently the installer uses -bg, but it seems like it'd be sensible for -g to imply that we want this partition to be attached at boot since that's presumably our root filesystem.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kevans created this revision.Jan 27 2020, 11:02 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 27 2020, 11:02 PM

Harbormaster completed remote builds in B28959: Diff 67379.Jan 27 2020, 11:02 PM

allanjude added reviewers: pjd, oshogbo.Jan 28 2020, 12:59 AM

This doesn't break multiple encrypted disks?
If I have 3 disk and only one should be decrypted by the loader?

In D23387#517340, @oshogbo wrote:

This doesn't break multiple encrypted disks?
If I have 3 disk and only one should be decrypted by the loader?

I'm not sure I follow- I have no intention of changing how loader determines what should be decrypted, just to reduce/eliminate the need to tag both GELIBOOT and BOOT to get the kernel to taste the partition that was tagged for decrypting by loader.

Oh sorry I miss read the patch.
Then this looks good to me :)

This revision is now accepted and ready to land.Feb 7 2020, 7:58 PM

Closed by commit rS357665: geli taste: allow GELIBOOT tagged providers as well (authored by kevans). · Explain WhyFeb 7 2020, 9:36 PM

This revision was automatically updated to reflect the committed changes.

kevans added a commit: rS357665: geli taste: allow GELIBOOT tagged providers as well.