It looks like D41592 depends on liveness tracking changes that are not in 5.0. Use a slightly hackish approach that works with 5.0 instead.

Thanks, I will try to take a detailed look at this soon. For future changes, and if you have reason to upload a new diff to this review, please upload with full context as described in https://wiki.freebsd.org/action/show/Phabricator

Needs rebase after rS327218

@meloun-miracle-cz that is, this fix works for you as well?

ping

ping

ping

Ping @gad

@kib can you close this?

Perhaps commit the ones that have been explicitly acknowledged (e.g. drivers) and rebase?

This looks reasonable to me.
@jmg, your thoughts?

This is what DT calls MFD (Multi Function Device) and I never knew what is the best way to represent it in our drivers.

No objection from me.

LGTM. I compared this to my backport+the three additional commits you identified, and the only difference was an addReservedSymbols declaration that I forgot in a header.

LGTM

Committed in rS326613: Update tcpdump to 4.9.2

In my wipbsd-12 branch as 8838eabfacb87fbf3781d9a5a79de88ffb859215

Fine with me.

I like the idea of having this support in ddb, but will defer to @jhb and @imp.

Commit link: rS302292
@wma can you close this review?

• update for 78c558ba097d8 (rS325001)
• use :C where applicable

I like the intent of this change. It's a bit unfortunate to have the #ifs but I also don't see a better way. Does NetBSD's find do the same thing? What is the #include "nbtool_config.h" for?

Ping.

Is this ready to commit now?

We might need to start calling out arm, armv6, armv7 separately -- it may be that only armv7 becomes tier-1

@stevek will you commit (with style fix)?

I agree with @ngie.

In D10335#214467, @jceel wrote:

Yes, the upstream is maintained at https://github.com/freenas/lib9p. I would like to keep it in a separate repo, as xhyve folks would also like to use it (as a git submodule).

ping?

5.0 or later is now in HEAD and 11.x. I intend to commit this to HEAD shortly.

ping?

@imp do you think you might look at this again soon? I may pick it up if you won't.

Set L3 csum flag if CSUM_IP is set

go fails with address randomization enabled