Bug 223722 add sys/class/net data to linsysfs

[cneirabustos_gmail.com]

Summary

Adds sys/class/net devices to linsysfs. Only two interfaces are created eth0 and lo and they expose the following properties:
address, addr_len, flags, ifindex, mty, tx_queue_len and type.

Test Plan

Mount linsysfs in a jail or in the host system and check if devices are created under sys/class/net and if properties are available.

[emaste]

Thanks, I will try to take a detailed look at this soon. For future changes, and if you have reason to upload a new diff to this review, please upload with full context as described in https://wiki.freebsd.org/action/show/Phabricator

[cem]

The patch does not conform to style(9).

[cneirabustos_gmail.com]

Fixed style.

[dchagin]

style (9)

sys/compat/linsysfs/linsysfs.c

125 ↗

(On Diff #55321)

tab until }?

141 ↗

(On Diff #55321)

extra line

163 ↗

(On Diff #55321)

remove '\n'

165 ↗

(On Diff #55321)

whitespace

169 ↗

(On Diff #55321)

add '\n'

187 ↗

(On Diff #55321)

same

200 ↗

(On Diff #55321)

same

235 ↗

(On Diff #55321)

whitespace in function, below too

[cneirabustos_gmail.com]

Fixed latest style issue.

[cneirabustos_gmail.com]

updated patch to address style(9) issues.

[dchagin]

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

[cneirabustos_gmail.com]

In D13656#422012, @dchagin wrote:

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Hi,

The only reason is that two devices are the minimum needed to expose to applications that use sys/class/net data.

[emaste]

For future updates (to this review, if any, or other reviews) please include context e.g. git diff -U9999

[dchagin]

sys/compat/linsysfs/linsysfs.c

268 ↗

(On Diff #55423)

btw, why lo instead of lo0?

[cem]

sys/compat/linsysfs/linsysfs.c

268 ↗

(On Diff #55423)

It's Linux's name for the loopback interface (not lo0).

[cneirabustos_gmail.com]

sys/compat/linsysfs/linsysfs.c

268 ↗

(On Diff #55423)

As @cem explained, the loopback device is named lo in Linux.

268 ↗

(On Diff #55423)

That's correct.

[dchagin]

head/sys/compat/linsysfs/linsysfs.c

5

Ar you really need this line? As I rewrote most of the patch? )

[cneirabustos_gmail.com]

head/sys/compat/linsysfs/linsysfs.c

5

Thank you very much @dchagin, the patch looks nicer now!. Thanks for your help on this one.
You could remove that line if needed.