Page MenuHomeFreeBSD
Differential D13656

Bug 223722 add sys/class/net data to linsysfs
ClosedPublic
Actions

Authored by cneirabustos_gmail.com on Dec 27 2017, 7:17 PM.
Tags
Referenced Files
Unknown Object (File)
Wed, Oct 22, 7:32 PM
Unknown Object (File)
Mon, Oct 20, 4:26 AM
Unknown Object (File)
Mon, Oct 20, 4:25 AM
Unknown Object (File)
Mon, Oct 20, 4:25 AM
Unknown Object (File)
Mon, Oct 20, 4:25 AM
Unknown Object (File)
Mon, Oct 20, 4:25 AM
Unknown Object (File)
Sun, Oct 19, 1:48 PM
Unknown Object (File)
Thu, Oct 16, 12:56 AM
View All Files
Subscribers
cem
dchagin
imp
Linux Emulation

Details

Reviewers
emaste
cem
dchagin
Commits
rS347218: Remove wrong copyright line. Discussed with Carlos Neira.
rS347204: Adds sys/class/net devices to linsysfs.
Summary

Adds sys/class/net devices to linsysfs. Only two interfaces are created eth0 and lo and they expose the following properties:
address, addr_len, flags, ifindex, mty, tx_queue_len and type.

Test Plan

Mount linsysfs in a jail or in the host system and check if devices are created under sys/class/net and if properties are available.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

cneirabustos_gmail.com created this revision.Dec 27 2017, 7:17 PM
Herald added a subscriber: imp. · View Herald TranscriptDec 27 2017, 7:17 PM
emaste added a comment.Dec 27 2017, 11:44 PM

Thanks, I will try to take a detailed look at this soon. For future changes, and if you have reason to upload a new diff to this review, please upload with full context as described in https://wiki.freebsd.org/action/show/Phabricator

cem requested changes to this revision.Jan 29 2018, 12:07 AM
cem added a subscriber: cem.

The patch does not conform to style(9).

This revision now requires changes to proceed.Jan 29 2018, 12:07 AM
cneirabustos_gmail.com updated this revision to Diff 55321.Mar 21 2019, 3:57 PM
cneirabustos_gmail.com edited the summary of this revision. (Show Details)
cneirabustos_gmail.com edited the test plan for this revision. (Show Details)

Fixed style.

dchagin added a subscriber: dchagin.Mar 24 2019, 7:29 AM

style (9)

sys/compat/linsysfs/linsysfs.c
125 ↗(On Diff #55321)

tab until }?

141 ↗(On Diff #55321)

extra line

163 ↗(On Diff #55321)

remove '\n'

165 ↗(On Diff #55321)

whitespace

169 ↗(On Diff #55321)

add '\n'

187 ↗(On Diff #55321)

same

200 ↗(On Diff #55321)

same

235 ↗(On Diff #55321)

whitespace in function, below too

cneirabustos_gmail.com updated this revision to Diff 55423.Mar 25 2019, 1:18 PM

Fixed latest style issue.

cneirabustos_gmail.com marked 8 inline comments as done.Mar 25 2019, 1:19 PM

updated patch to address style(9) issues.

dchagin added a comment.Mar 25 2019, 2:07 PM

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

cneirabustos_gmail.com added a comment.Mar 25 2019, 5:15 PM
In D13656#422012, @dchagin wrote:

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Hi,

The only reason is that two devices are the minimum needed to expose to applications that use sys/class/net data.

dchagin added a reviewer: dchagin.Apr 30 2019, 6:32 PM
emaste added a comment.Apr 30 2019, 8:35 PM

For future updates (to this review, if any, or other reviews) please include context e.g. git diff -U9999

dchagin added inline comments.May 1 2019, 8:05 PM
sys/compat/linsysfs/linsysfs.c
268 ↗(On Diff #55423)

btw, why lo instead of lo0?

cem added inline comments.May 1 2019, 9:19 PM
sys/compat/linsysfs/linsysfs.c
268 ↗(On Diff #55423)

It's Linux's name for the loopback interface (not lo0).

cneirabustos_gmail.com marked 2 inline comments as done.May 6 2019, 5:39 PM
cneirabustos_gmail.com added inline comments.
sys/compat/linsysfs/linsysfs.c
268 ↗(On Diff #55423)

As @cem explained, the loopback device is named lo in Linux.

268 ↗(On Diff #55423)

That's correct.

cneirabustos_gmail.com marked an inline comment as done.May 6 2019, 5:40 PM
This revision was not accepted when it landed; it landed in state Needs Review.May 6 2019, 8:01 PM
Closed by commit rS347204: Adds sys/class/net devices to linsysfs. (authored by dchagin). · Explain Why
This revision was automatically updated to reflect the committed changes.
dchagin added inline comments.May 6 2019, 9:29 PM
head/sys/compat/linsysfs/linsysfs.c
5 ↗(On Diff #57105)

Ar you really need this line? As I rewrote most of the patch? )

cneirabustos_gmail.com marked an inline comment as done.May 6 2019, 11:07 PM
cneirabustos_gmail.com added inline comments.
head/sys/compat/linsysfs/linsysfs.c
5 ↗(On Diff #57105)

Thank you very much @dchagin, the patch looks nicer now!. Thanks for your help on this one.
You could remove that line if needed.

Revision Contents
Changeset List

PathSize
linsysfs.c
linsysfs.c.orig
214 lines

Diff 37105

View Options

linsysfs.c

Loading...