This looks fine to me. Let me know if there's anything else I need to do for it.

In D16518#353086, @markj wrote:

In D16518#352929, @gad wrote:

[...] I'll submit this anyway, if only to prove that I do read my email. 🙂

Does this qualify for a "Reviewed by: gad" in the commit message?

I haven't looked at newsyslog in awhile, but I'm happy to see someone attempting this cleanup.

So, I'm finally getting around to looking at this. The delay was that I didn't have a freebsd-12.current system running. And now that I have a current system to test changes on, it looks like this issue was solved back in revision 303449 by ed, Thu Jul 28 16:02:30 2016 UTC. See revision 303449

(sorry for the late noise. For some odd reason, today is the first day I've been able to connect to this page, although I've tried since last Thursday. I suspect there was a problem in the browser on my machine).

In D9637#283208, @emaste wrote:

Ping @gad

This was handled by the commit which was referenced earlier.

Accepting this, so I can later close it.

Many years ago I did some work on newsyslog. I could handle the review and commit of this update if that's okay with other reviewers.

I'm in the path of the big snowstorm which is supposed to hit tomorrow, so I might not respond to this for a few days. But once we've recovered from that, I'd be willing to commit my other patch for this along with the fix to skimprintcap.c. If nothing else, it shows that I'm still alive and paying (some) attention to lpr & friends.

Hmm. Odd that it didn't build. It did compile on my system, although I didn't do much more than compile it.

Well, I tried to upload my diff as an "update", and that showed up as D9982 .

Hmm. I guess that wasn't the best way to upload an example diff...

[ thanks for contacting me ]