map mips TARGET_ARCH to triples
AcceptedPublic

Authored by emaste on Aug 30 2017, 5:47 PM.

Details

Reviewers
imp
jhb
Summary
  • strip trailing hf
  • use mips64 for mipsn32

Diff Detail

Lint
Lint Skipped
Unit
Unit Tests Skipped
emaste created this revision.Aug 30 2017, 5:47 PM
imp added inline comments.Aug 30 2017, 5:54 PM
Makefile.inc1
640

Might want to use C instead of S here. While it's true it isn't an extended regex, neither is the first one...

emaste added inline comments.Aug 30 2017, 6:15 PM
Makefile.inc1
640

Or we could make the first one :S. On a quick look I think we have about 2x as many :S in the tree as :C and about three quarters of the :Cs could be :S.

Anyway if you're otherwise OK with the change I will commit it with whichever form is preferred.

jhb added a comment.Aug 30 2017, 7:58 PM

This already strips 'hf'? The only change in the diff seems to be the n32 fix?

Oops, this was committed in two parts to my local tree and this diff represents only the second change. The file in FreeBSD svn currently has only ${TARGET_ARCH:C/amd64/x86_64/}

jhb accepted this revision.Aug 30 2017, 9:30 PM

Ok.

This revision is now accepted and ready to land.Aug 30 2017, 9:30 PM