Fix a memory leak in libiberty

[trix_juniper.net]

Summary

The function make_relative_prefix_1 does not properly free locally allocated memory when it returns early.

Free the memory associated with the variables full_programe, bin_dirs, prog_dirs, and prefix_dirs when the
function returns early.

Test Plan

Run clang's static analyzer, scan-build, before to reproduce the problem; run scan-build after to show problem is resolved.

[trix_juniper.net]

Thanks!
Now if someone could commit it..
Tom

[stevek]

contrib/binutils/libiberty/make-relative-prefix.c

302 ↗

(On Diff #25435)

These if statements should really use the style of the file.

if (prog_dirs == NULL)
  {
    free (full_progname);

...etc.

Note the opening/closing braces on their own lines 2 space indented, with the rest of the block an additional 2 space indented.

[emaste]

@stevek will you commit (with style fix)?

[stevek]

In D9691#279425, @emaste wrote:

@stevek will you commit (with style fix)?

Sure, I can do that.