Fix a memory leak in libiberty
ClosedPublic
Actions

Authored by trix_juniper.net on Feb 20 2017, 5:06 PM.

Details

Reviewers

jhibbits
emaste
stevek

Commits

rS326636: The function make_relative_prefix_1 does not properly free locally

Summary

The function make_relative_prefix_1 does not properly free locally allocated memory when it returns early.

Free the memory associated with the variables full_programe, bin_dirs, prog_dirs, and prefix_dirs when the
function returns early.

Test Plan

Run clang's static analyzer, scan-build, before to reproduce the problem; run scan-build after to show problem is resolved.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

trix_juniper.net updated this revision to Diff 25435.Feb 20 2017, 5:06 PM

trix_juniper.net retitled this revision from to Fix a memory leak in libiberty.

trix_juniper.net updated this object.

trix_juniper.net edited the test plan for this revision. (Show Details)

trix_juniper.net added reviewers: stevek, jhibbits, emaste.

trix_juniper.net set the repository for this revision to rS FreeBSD src repository - subversion.

Herald added a subscriber: imp. · View Herald TranscriptFeb 20 2017, 5:06 PM

jhibbits accepted this revision.May 30 2017, 8:32 PM

This revision is now accepted and ready to land.May 30 2017, 8:32 PM

Thanks!
Now if someone could commit it..
Tom

stevek added inline comments.May 31 2017, 9:26 PM

contrib/binutils/libiberty/make-relative-prefix.c
302	These if statements should really use the style of the file. if (prog_dirs == NULL) { free (full_progname); ...etc. Note the opening/closing braces on their own lines 2 space indented, with the rest of the block an additional 2 space indented.

@stevek will you commit (with style fix)?

In D9691#279425, @emaste wrote:

@stevek will you commit (with style fix)?

Sure, I can do that.

Closed by commit rS326636: The function make_relative_prefix_1 does not properly free locally (authored by stevek). · Explain WhyDec 6 2017, 9:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

contrib/

binutils/

libiberty/

make-relative-prefix.c

16 lines

Diff 25435

View Options

contrib/binutils/libiberty/make-relative-prefix.c

Fix a memory leak in libibertyClosedPublicActions