Page MenuHomeFreeBSD

trix_juniper.net (Tom Rix)
User

Projects

User does not belong to any projects.

User Details

User Since
Feb 16 2017, 5:12 PM (131 w, 1 d)

Recent Activity

May 30 2017

trix_juniper.net added a comment to D9691: Fix a memory leak in libiberty.

Thanks!
Now if someone could commit it..
Tom

May 30 2017, 9:39 PM

May 9 2017

trix_juniper.net added a comment to D10469: The c11 appendix K string functions.

The location of the external project is https://github.com/trixirt/libc11ext

May 9 2017, 7:30 PM

May 6 2017

trix_juniper.net added a comment to D10469: The c11 appendix K string functions.

I am moving this work to an external project.
It is currently being reviewed internally.
I will let you know when it happens, my guess is in a week or two.

May 6 2017, 2:13 PM

Apr 24 2017

trix_juniper.net added a comment to D10469: The c11 appendix K string functions.

The arguements in n1967 come down to 'It's safer but... '
For applications that want safer and are will to accept the cost, app. K is a good option.
If it is a seperate lib in the base, that is fine with me.

Apr 24 2017, 2:00 PM

Apr 23 2017

trix_juniper.net created D10469: The c11 appendix K string functions.
Apr 23 2017, 8:02 PM

Mar 30 2017

trix_juniper.net added inline comments to D10161: Continuation of D9903..
Mar 30 2017, 3:39 PM

Mar 28 2017

trix_juniper.net added a comment to D9903: Add C11 Appendix K function memset_s.

My comment is in D10161

Mar 28 2017, 1:49 PM
trix_juniper.net added inline comments to D10161: Continuation of D9903..
Mar 28 2017, 1:47 PM
trix_juniper.net updated the diff for D9903: Add C11 Appendix K function memset_s.

Cleanups
Simplify logic for STDC_WANT_LIB_EXT1 in cdefs.h, remove it's CFLAGS in makefiles.

Mar 28 2017, 1:47 AM

Mar 24 2017

trix_juniper.net added a comment to D9903: Add C11 Appendix K function memset_s.

I do not have commit permissions.

Mar 24 2017, 10:46 PM
trix_juniper.net updated the diff for D9903: Add C11 Appendix K function memset_s.

Move STDC_WANT_LIB_EXT1 to its own if block
Cleanups

Mar 24 2017, 9:32 PM

Mar 22 2017

trix_juniper.net created D10097: Fix memory leak in ctm.
Mar 22 2017, 5:05 PM

Mar 21 2017

trix_juniper.net created D10073: Fix memory leak in memcontrol.
Mar 21 2017, 1:16 PM
trix_juniper.net created D10069: Fix memory leaks in groff.
Mar 21 2017, 12:09 AM

Mar 20 2017

trix_juniper.net updated the diff for D10062: Fix memory leak in mount.

More surrounding context

Mar 20 2017, 4:08 PM
trix_juniper.net created D10063: Fix memory leak in autofs.
Mar 20 2017, 3:54 PM
trix_juniper.net created D10062: Fix memory leak in mount.
Mar 20 2017, 3:30 PM
trix_juniper.net updated the diff for D9903: Add C11 Appendix K function memset_s.

Add __EXT1_VISIBLE construct to cdefs.h
Fix some style issues

Mar 20 2017, 3:01 PM

Mar 15 2017

trix_juniper.net added a comment to D10004: Fix memory leaks in syslogd.

No worries.
Thanks for the commit!
Tom

Mar 15 2017, 6:24 PM
trix_juniper.net updated the diff for D10004: Fix memory leaks in syslogd.

remove 'end' label and 'ret' variable

Mar 15 2017, 6:00 PM
trix_juniper.net added a comment to D10004: Fix memory leaks in syslogd.

This conflicts with earlier comment to have goto.
This is the pattern I use to have a single return, if you want 2 returns,
I could remove the Œret¹ and Œend:¹ and return(-1) at the bottom of the
err: block.

Mar 15 2017, 5:48 PM
trix_juniper.net updated the diff for D10004: Fix memory leaks in syslogd.

Collect the error handling in allowaddr to the 'err' label

Mar 15 2017, 5:22 PM

Mar 14 2017

trix_juniper.net added a comment to D10004: Fix memory leaks in syslogd.

I¹ll take care of this tomorrow.

Mar 14 2017, 11:38 PM
trix_juniper.net created D10009: Fix a memory leak in bhyve.
Mar 14 2017, 9:43 PM
trix_juniper.net created D10008: Fix a memory leak in bsdinstall.
Mar 14 2017, 9:15 PM
trix_juniper.net added a comment to D9996: Fix a memory leak in ccdconfig.

I am pedantically scrubbing all of the memory leaks and this is a leak.
Problems must fixed so they don¹t turn up in future scans.

Mar 14 2017, 5:43 PM
trix_juniper.net created D10004: Fix memory leaks in syslogd.
Mar 14 2017, 5:09 PM
trix_juniper.net created D10001: Fix memory leak in vmstat.
Mar 14 2017, 3:44 PM
trix_juniper.net created D9996: Fix a memory leak in ccdconfig.
Mar 14 2017, 3:11 AM
trix_juniper.net updated the diff for D9903: Add C11 Appendix K function memset_s.

Add set_contraint_handler_s
Move setting of STDC_WANT_LIB_EXT1 to makefiles
Fix some style issues

Mar 14 2017, 2:04 AM

Mar 13 2017

trix_juniper.net created D9994: Remove unused static declaration.
Mar 13 2017, 9:11 PM
trix_juniper.net created D9992: Fix a memory leak in dhclient.
Mar 13 2017, 4:56 PM
trix_juniper.net created D9991: Fix a memory leak in atmconfig.
Mar 13 2017, 4:24 PM
trix_juniper.net updated the diff for D9962: Fix a memory leak in ipfw.

change 'lav' to 'oav'

Mar 13 2017, 3:48 PM

Mar 12 2017

trix_juniper.net added a comment to D9962: Fix a memory leak in ipfw.

No commit bit.
Yes, l as in local, there have been similar problems where the pointer
variable is a passed in parameter.
Let me do the o change first, I¹ll take take of that tomorrow.
Tom

Mar 12 2017, 10:37 PM
trix_juniper.net created D9979: Fix a use-after-free in systat.
Mar 12 2017, 3:56 PM
trix_juniper.net created D9978: Fix memory leak in swapon.
Mar 12 2017, 3:16 PM
trix_juniper.net added a comment to D9856: Fix a memory leak in fdread.

Yes, please commit. I do not have commit perms.
Thank you,
Tom

Mar 12 2017, 2:35 PM

Mar 11 2017

trix_juniper.net created D9962: Fix a memory leak in ipfw.
Mar 11 2017, 4:38 PM
trix_juniper.net created D9960: Fix a memory leak in libmemstat.
Mar 11 2017, 4:06 PM
trix_juniper.net created D9954: Fix a memory leak in lpr.
Mar 11 2017, 1:53 AM
trix_juniper.net added a comment to D9856: Fix a memory leak in fdread.

This is the before, the line number is a bit screwed up because i commented out my change.
The after has memory leak removed.

Mar 11 2017, 1:11 AM
trix_juniper.net created D9953: Fix a memory leak in mptutil.
Mar 11 2017, 12:33 AM

Mar 10 2017

trix_juniper.net added a comment to D9856: Fix a memory leak in fdread.

I will have to reproduce these, I will send it out asap.

Mar 10 2017, 4:34 AM

Mar 7 2017

trix_juniper.net added a comment to D9903: Add C11 Appendix K function memset_s.

If we don’t give them the function to register the handler there shouldn’t
be any expectation ;)

The handler interface is a part of the full K support and I believe
overkill if we only have a single K function.
I am in favor of full support.
Is that what everyone wants ?

A new idea..
What do people think about making the pointer access safer ?
It should be possible to look into the processes memory space and tell if
the memory accessed by the function is mostly valid.

Tom

Mar 7 2017, 2:49 PM

Mar 6 2017

trix_juniper.net added a comment to D9903: Add C11 Appendix K function memset_s.

The handlers certainly would be useful if a full implementation of K was
done.
For a single function I don¹t think it would be very useful.
How much more useful would a handler have over a user just checking the
return ?

Mar 6 2017, 8:08 PM
trix_juniper.net added a comment to D9903: Add C11 Appendix K function memset_s.

I am working on the style problems.

Mar 6 2017, 6:50 PM
trix_juniper.net added a comment to D9903: Add C11 Appendix K function memset_s.

The reason for adding this function is to improve security.
Memset is used to overwrite sensitive memory.
But the compiler can legally optimize away a memset.
The compiler can not optimize away memset_s.

Mar 6 2017, 2:42 PM

Mar 5 2017

trix_juniper.net retitled D9903: Add C11 Appendix K function memset_s from to Add C11 Appendix K function memset_s.
Mar 5 2017, 7:23 PM
trix_juniper.net retitled D9899: Fix memory leaks in dhclient from to Fix memory leaks in dhclient.
Mar 5 2017, 2:07 PM
trix_juniper.net retitled D9897: Fix memory leak in ident from to Fix memory leak in ident.
Mar 5 2017, 1:21 PM

Mar 3 2017

trix_juniper.net retitled D9878: Fix a memory leak in bluetooth/hccontrol from to Fix a memory leak in bluetooth/hccontrol.
Mar 3 2017, 5:34 PM
trix_juniper.net retitled D9877: Fix a memory leak in ipfilter from to Fix a memory leak in ipfilter.
Mar 3 2017, 4:57 PM
trix_juniper.net retitled D9872: Fix a memory leak in heimdal from to Fix a memory leak in heimdal.
Mar 3 2017, 1:14 AM

Mar 2 2017

trix_juniper.net retitled D9867: Fix a memory leak in libutil from to Fix a memory leak in libutil.
Mar 2 2017, 3:19 PM
trix_juniper.net retitled D9865: Fix a memory leak in i2c from to Fix a memory leak in i2c.
Mar 2 2017, 2:35 PM
trix_juniper.net retitled D9856: Fix a memory leak in fdread from to Fix a memory leak in fdread.
Mar 2 2017, 4:53 AM
trix_juniper.net retitled D9852: Fix a memory leak in ppp from to Fix a memory leak in ppp.
Mar 2 2017, 1:41 AM
trix_juniper.net retitled D9850: Fix 'last' memory leak from to Fix 'last' memory leak .
Mar 2 2017, 12:06 AM

Feb 27 2017

trix_juniper.net added a comment to D9787: Fix memory leak in openssh.

I have submitted bug reports to openssh here
https://bugzilla.mindrot.org/show_bug.cgi?id=2683
https://bugzilla.mindrot.org/show_bug.cgi?id=2684

Feb 27 2017, 3:11 PM

Feb 26 2017

trix_juniper.net added a comment to D9777: Fix memory issues with nvi.

Sure, let me give it a try.

Feb 26 2017, 3:36 PM

Feb 25 2017

trix_juniper.net added a comment to D9787: Fix memory leak in openssh.

Ok, i will get this upstreamed.

Feb 25 2017, 5:37 PM

Feb 24 2017

trix_juniper.net added a comment to D9689: Fix a memory leak in telnetd.

Credit goes to clang¹s static analyzer scan-build.
I only read the reports it generated.
Tom

Feb 24 2017, 6:40 PM
trix_juniper.net retitled D9787: Fix memory leak in openssh from to Fix memory leak in openssh.
Feb 24 2017, 6:10 PM
trix_juniper.net added a comment to D9778: Fix a memory leak in grep.

Yes I am aware of the bsd-ism.
Generally it isn¹t a good idea to use ism¹s.
In this case the problem is in grep which is gnu, and not bsd.
Tom

Feb 24 2017, 3:37 PM
trix_juniper.net retitled D9778: Fix a memory leak in grep from to Fix a memory leak in grep.
Feb 24 2017, 12:17 AM

Feb 23 2017

trix_juniper.net retitled D9777: Fix memory issues with nvi from to Fix memory issues with nvi.
Feb 23 2017, 11:28 PM
trix_juniper.net updated the diff for D9768: Fix memory leaks in mdmfs.

I agree these should also be freed.
I took a second look at the scan-view output and it did not complain which is troubling.

Feb 23 2017, 11:22 PM
trix_juniper.net added a comment to D9767: Fix a memory leak in libctf.

Yes, that would be helpful.
At this time, I do not have any more static analysis fixes for dtrace.
Thanks
Tom

Feb 23 2017, 5:45 PM
trix_juniper.net retitled D9768: Fix memory leaks in mdmfs from to Fix memory leaks in mdmfs.
Feb 23 2017, 4:47 PM
trix_juniper.net retitled D9767: Fix a memory leak in libctf from to Fix a memory leak in libctf.
Feb 23 2017, 4:41 PM

Feb 21 2017

trix_juniper.net edited reviewers for D9705: Fix memory leaks in libdtrace, added: stevek, markj; removed: gnn.
Feb 21 2017, 7:19 PM
trix_juniper.net retitled D9705: Fix memory leaks in libdtrace from to Fix memory leaks in libdtrace.
Feb 21 2017, 7:18 PM

Feb 20 2017

trix_juniper.net retitled D9691: Fix a memory leak in libiberty from to Fix a memory leak in libiberty.
Feb 20 2017, 5:06 PM
trix_juniper.net retitled D9690: Fix a memory leak in newfs_msdos from to Fix a memory leak in newfs_msdos.
Feb 20 2017, 4:36 PM
trix_juniper.net retitled D9689: Fix a memory leak in telnetd from to Fix a memory leak in telnetd.
Feb 20 2017, 3:55 PM
trix_juniper.net updated the diff for D9663: Fix a memory leak with add_mapping.

moved free(copy) to last use of copy and poisoned copy after the free

Feb 20 2017, 3:04 PM

Feb 19 2017

trix_juniper.net retitled D9676: Fix memory leaks in route from to Fix memory leaks in route.
Feb 19 2017, 5:52 PM
trix_juniper.net retitled D9675: Fix a memory leak in bridge_interfaces. from to Fix a memory leak in bridge_interfaces..
Feb 19 2017, 5:30 PM
trix_juniper.net retitled D9673: Fix several memory problems in ldns from to Fix several memory problems in ldns.
Feb 19 2017, 4:34 PM
trix_juniper.net updated the diff for D9663: Fix a memory leak with add_mapping.
Feb 19 2017, 3:44 PM

Feb 18 2017

trix_juniper.net retitled D9663: Fix a memory leak with add_mapping from to Fix a memory leak with add_mapping.
Feb 18 2017, 2:08 PM
trix_juniper.net retitled D9661: Fix a memory leak with fw_check_device_ready from to Fix a memory leak with fw_check_device_ready.
Feb 18 2017, 1:02 PM

Feb 17 2017

trix_juniper.net retitled D9654: Fix a memory leak in set80211chanlist from to Fix a memory leak in set80211chanlist.
Feb 17 2017, 6:39 PM
trix_juniper.net retitled D9652: fix memory leak in 'finger' from to fix memory leak in 'finger'.
Feb 17 2017, 5:50 PM

Feb 16 2017

trix_juniper.net retitled D9637: Fix a memory leak with the variable logfname from to Fix a memory leak with the variable logfname.
Feb 16 2017, 5:24 PM