Add "Pull Request" to the devel/subversion commit template
AcceptedPublic

Authored by asomers on Nov 21 2017, 2:37 AM.

Details

Reviewers
emaste
imp
bjk
Summary

Add "Pull Request" to the devel/subversion commit template

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12898
Build 13160: arc lint + arc unit
asomers created this revision.Nov 21 2017, 2:37 AM
rpokala added inline comments.
devel/subversion/files/extra-patch-fbsd-template
93

This looks like a gratuitous whitespace change...? It's not from D13178 at any rate.

asomers added inline comments.Nov 21 2017, 2:55 AM
devel/subversion/files/extra-patch-fbsd-template
93

I generated the patch with "make makepatch". Notice that the effect of the patch is the same; there is no change to the patched file. The difference is just a matter of which blank line diff thinks is new, and which diff thinks is context.

asomers updated this revision to Diff 35524.Nov 21 2017, 3:00 AM

Switch order of "Pull Request" and "Differential Revision"

mjg added a subscriber: mjg.Nov 21 2017, 3:41 AM

while here can you add 'tested by' and 'discussed with'?

mat added a comment.Nov 24 2017, 3:53 PM

You should also add it to the various hooks/scripts/log-police.py in all the svnadmin repositories.

In D13179#275428, @mat wrote:

You should also add it to the various hooks/scripts/log-police.py in all the svnadmin repositories.

Good idea. I've done that in my working copy, but I can't upload it to phabricator because phabricator diffs are anchored to /head/, not /. Here's what the svnadmin portion of the diff looks like:

Index: svnadmin/hooks/scripts/log-police.py
===================================================================
--- svnadmin/hooks/scripts/log-police.py        (revision 454858)
+++ svnadmin/hooks/scripts/log-police.py        (working copy)
@@ -57,6 +57,7 @@
     if line == "Changes:": continue
     if line == "With hat:": continue
     if line == "Sponsored by:": continue
+    if line == "Pull Request:": continue
     if line == "Differential Revision:": continue
     s = s + line + "\n"
   s = s.rstrip() + "\n"
In D13179#274381, @mjg wrote:

while here can you add 'tested by' and 'discussed with'?

I would rather do that in a separate commit, if that's ok with you.

emaste accepted this revision.Dec 5 2017, 9:49 PM

Fine with me.

This revision is now accepted and ready to land.Dec 5 2017, 9:49 PM

@emaste, did you mean to approve D13178 instead? That's the review for the src repo. This review is for ports.

@mat is this fine by you?

mat added a comment.Wed, Jan 10, 2:39 PM

Mmmm, I don't really know. The ports tree does not support patches from pull requests, only from our bugzilla, it would be much better to have the pull-request -> bugzilla gateway finally working.

In that case, @mat, would you like me to commit the part to devel/subversion (so it can be used with base), but not the part to svnadmin?