Add "Pull Request" to the devel/subversion commit template

[asomers]

Summary

Add "Pull Request" to the devel/subversion commit template

[rpokala]

devel/subversion/files/extra-patch-fbsd-template

93

This looks like a gratuitous whitespace change...? It's not from D13178 at any rate.

[asomers]

devel/subversion/files/extra-patch-fbsd-template

93

I generated the patch with "make makepatch". Notice that the effect of the patch is the same; there is no change to the patched file. The difference is just a matter of which blank line diff thinks is new, and which diff thinks is context.

[asomers]

Switch order of "Pull Request" and "Differential Revision"

[mjg]

while here can you add 'tested by' and 'discussed with'?

[mat]

You should also add it to the various hooks/scripts/log-police.py in all the svnadmin repositories.

[asomers]

In D13179#275428, @mat wrote:

You should also add it to the various hooks/scripts/log-police.py in all the svnadmin repositories.

Good idea. I've done that in my working copy, but I can't upload it to phabricator because phabricator diffs are anchored to /head/, not /. Here's what the svnadmin portion of the diff looks like:

Index: svnadmin/hooks/scripts/log-police.py
===================================================================
--- svnadmin/hooks/scripts/log-police.py        (revision 454858)
+++ svnadmin/hooks/scripts/log-police.py        (working copy)
@@ -57,6 +57,7 @@
     if line == "Changes:": continue
     if line == "With hat:": continue
     if line == "Sponsored by:": continue
+    if line == "Pull Request:": continue
     if line == "Differential Revision:": continue
     s = s + line + "\n"
   s = s.rstrip() + "\n"

[asomers]

In D13179#274381, @mjg wrote:

while here can you add 'tested by' and 'discussed with'?

I would rather do that in a separate commit, if that's ok with you.

[emaste]

Fine with me.

[asomers]

@emaste, did you mean to approve D13178 instead? That's the review for the src repo. This review is for ports.

[asomers]

@mat is this fine by you?

[mat]

Mmmm, I don't really know. The ports tree does not support patches from pull requests, only from our bugzilla, it would be much better to have the pull-request -> bugzilla gateway finally working.

[asomers]

In that case, @mat, would you like me to commit the part to devel/subversion (so it can be used with base), but not the part to svnadmin?

[emaste]

Ping

[emaste]

In D13179#289885, @mat wrote:

Mmmm, I don't really know. The ports tree does not support patches from pull requests, only from our bugzilla, it would be much better to have the pull-request -> bugzilla gateway finally working.

Note that many FreeBSD src committers use the svn port, it's not used only for commits to the ports tree. And although there is no direct tooling for handling pull requests, it's relatively straightforward for any committer who is already using a git-based workflow to bring in changes from pull requests, and when those arrive in FreeBSD they should have consistent metadata.

[asomers]

Overcome by events. RIP SVN.

[emaste]

We do have Pull Request in the new git template