Page MenuHomeFreeBSD

Add Pull Request to the Subversion commit template
ClosedPublic

Authored by asomers on Nov 21 2017, 2:36 AM.

Details

Summary

Add Pull Request to the Subversion commit template

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I would put it before Differential Revision: to help cement the idea that D-R should go last (even though you'd generally not have both of these on the same commit) and because Differential Revision: is too long and pushes the rest of the text over to the right.

switch order of "Pull Request" and "Differential Revision"

At @mat's request, I'm also making a change to the svnadmin area. However, I can't upload that part to phabricator, because phabricator diffs are anchored to /head instead of /. But here's what it looks like:

Index: svnadmin/hooks/scripts/log-police.py
===================================================================
--- svnadmin/hooks/scripts/log-police.py        (revision 317859)
+++ svnadmin/hooks/scripts/log-police.py        (working copy)
@@ -57,6 +57,7 @@
     if line == "Changes:": continue
     if line == "With hat:": continue
     if line == "Sponsored by:": continue
+    if line == "Pull Request:": continue
     if line == "Differential Revision:": continue
     s = s + line + "\n"
   s = s.rstrip() + "\n"
This revision was not accepted when it landed; it landed in state Needs Review.Jan 9 2018, 9:02 PM
This revision was automatically updated to reflect the committed changes.

Note that before using this, it would be much better to finally have the pull request -> PR gateway working.