Update OptionalObsoleteFiles.inc after 021385aba562
ClosedPublic
Actions

Authored by arichardson on Sep 20 2021, 8:48 AM.

Details

Reviewers

emaste
dim
imp

Commits

rG176dbfa36090: Update OptionalObsoleteFiles.inc after 021385aba562
rG5b356e6395c1: Update OptionalObsoleteFiles.inc after 021385aba562
rG88c027338f18: Update OptionalObsoleteFiles.inc after 021385aba562

Summary

I forgot to update this file so make delete-old would incorrectly remove
the newly-installed LLVM binutils. While touching the file also update
for 8e1c989abbd1 since ObsoleteFiles.inc now inludes the tablegen binaries.

Reported by: Herbert J. Skuhra <herbert@gojira.at>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Sep 20 2021, 8:48 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 20 2021, 8:48 AM

arichardson requested review of this revision.Sep 20 2021, 8:48 AM

Harbormaster completed remote builds in B41602: Diff 95380.Sep 20 2021, 8:48 AM

arichardson added a subscriber: herbert_gojira.at.Sep 20 2021, 8:50 AM

Also add the manpages

Harbormaster completed remote builds in B41604: Diff 95385.Sep 20 2021, 11:38 AM

emaste added inline comments.Sep 20 2021, 1:43 PM

tools/build/mk/OptionalObsoleteFiles.inc
1222	Is `&&` correct? If CLANG is on but LLVM_BINUTILS is not we want to remove them?

arichardson added inline comments.Sep 20 2021, 1:46 PM

tools/build/mk/OptionalObsoleteFiles.inc
1222	If `MK_CLANG==yes` and `MK_LLVM_BINUTILS==no` we should keep the files (same for `MK_CLANG==no` and `MK_LLVM_BINUTILS==yes`), so this condition should be correct? Right now they are deleted in the second case.