Add NOTES entries and fix extraneous SYSCTL_ADD_INT() options revealed by LINT build
Details
- Reviewers
mjg • hselasky manu - Commits
- rG0f0379fa5581: hid: Add recently imported drivers to NOTES
build LINT kernel
Diff Detail
- Repository
- rG FreeBSD src repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
sys/conf/NOTES | ||
---|---|---|
2856 | I already added "device hid" in NOTES, so please rebase your patch! |
Looks good. Just make sure LINT builds.
sys/conf/NOTES | ||
---|---|---|
2415–2416 | # Generic HID support -> # HID support |
sys/amd64/conf/NOTES | ||
---|---|---|
613 | I'd prefer we put this in sys/conf/NOTES as well. | |
sys/conf/NOTES | ||
2598 | Is there some reason this is commented out? If it's not normally on in GENERIC, it should be here, if it is normally on and we want to support things with it off, it shouldn't be here, though it's a mixed bag if that's commented out with a comment about why or it simply not here. I prefer the former. But commented out w/o a reason will invite others to remove either the '#' or the whole thing when 'cleaning up' this. | |
sys/dev/hid/hidmap.c | ||
755 | This is unrelated and should be committed separately, here and elsewhere in this review (iichid.c) |
sys/amd64/conf/NOTES | ||
---|---|---|
613 | HID-over-I2C depends on ACPI as it read configuration through _DSM method call (Microsoft specs requires that). That means it is architecture dependent at least for now. | |
sys/conf/NOTES | ||
2598 | This option only changes usbhid probe priority and adds/removes PnP IDs to different drivers. I will add comment about that. | |
sys/dev/hid/hidmap.c | ||
755 | sysctl changes stays in separate commit in my repo. |
sys/conf/NOTES | ||
---|---|---|
2598 | Really, It is better to enable it in a case of "no difference". Just to not confuse others. |