Differential D58854

net80211: fix WEP transmit
ClosedPublic
Actions

Authored by adrian on Sat, Aug 15, 2:41 AM.

Tags

Referenced Files

	Unknown Object (File)
	Sun, Aug 23, 2:42 AM

	Unknown Object (File)
	Sat, Aug 22, 6:06 PM

	Unknown Object (File)
	Sat, Aug 22, 2:57 PM

	Unknown Object (File)
	Sat, Aug 22, 2:50 PM

	Unknown Object (File)
	Sat, Aug 22, 6:09 AM

	Unknown Object (File)
	Fri, Aug 21, 9:00 PM

	Unknown Object (File)
	Fri, Aug 21, 11:51 AM

	Unknown Object (File)
	Fri, Aug 21, 11:50 AM

View All 15 Files

Subscribers

Details

Reviewers

Commits

rG874035c11cd4: net80211: fix WEP transmit

Summary

This was broken in 2022 with a security fix (61605e0ae5d8f) which
disallowed defaulting to the default TX key if there's no unicast
key. Unfortunately this path was also used by WEP transmit.

To fix it, add a separate check which ensures that WEP is configured
(authtype OPEN, privacy enabled) - then also check if the default TX
key is set and that said key is a WEP key.

Fixes: 61605e0ae5d8f

Locally tested:

rtwn(4) AP and rtwn(4) STA w/ static WEP keys configured

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 75600
Build 72483: arc lint + arc unit

Event Timeline

adrian created this revision.Sat, Aug 15, 2:41 AM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptSat, Aug 15, 2:41 AM

adrian requested review of this revision.Sat, Aug 15, 2:41 AM

Harbormaster completed remote builds in B75600: Diff 184084.Sat, Aug 15, 2:41 AM

adrian added a parent revision: D58705: net80211: add key get/set methods.Sat, Aug 15, 2:42 AM

adrian added a child revision: D58384: net80211: migrate the ioctl API to a 128 bit specific API + use key API.

adrian added a reviewer: bz.Sat, Aug 15, 2:44 AM

adrian added a project: wireless.

also it would be nice to count/log the drops here...

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Aug 19, 2:07 AM

Closed by commit rG874035c11cd4: net80211: fix WEP transmit (authored by adrian). · Explain Why

This revision was automatically updated to reflect the committed changes.

adrian added a commit: rG874035c11cd4: net80211: fix WEP transmit.

Revision Contents
Changeset List

Path

Size

sys/

net80211/

ieee80211_crypto.c

18 lines

Diff 184084

sys/net80211/ieee80211_crypto.c

Loading...