Paths

Table of Contentst

Differential D45740

net: Remove unneeded NULL check for the allocated ifnet
ClosedPublic
Actions

Authored by zlei on Jun 26 2024, 8:58 AM.

Tags

None

Referenced Files

	F106199377: D45740.id140440.diff
	Fri, Dec 27, 1:08 AM

	Unknown Object (File)
	Sat, Nov 30, 9:00 PM

	Unknown Object (File)
	Nov 25 2024, 8:16 AM

	Unknown Object (File)
	Nov 23 2024, 2:17 AM

	Unknown Object (File)
	Nov 17 2024, 6:11 PM

	Unknown Object (File)
	Nov 17 2024, 10:31 AM

	Unknown Object (File)
	Nov 8 2024, 1:40 PM

	Unknown Object (File)
	Nov 8 2024, 1:36 PM

View All 57 Files

Subscribers

vegeta_tuxpowered.net

Details

Reviewers

glebius
andrew
shurd
manu
kp
imp
stevek

Group Reviewers

network
iflib

Commits

rGf500e5c6c99b: net: Remove unneeded NULL check for the allocated ifnet
rG6b1f530935c5: net: Remove unneeded NULL check for the allocated ifnet
rGaa3860851b9f: net: Remove unneeded NULL check for the allocated ifnet

Summary

Change 4787572d0580 made if_alloc_domain() never fail, then also does the
wrappers if_alloc(), if_alloc_dev() and if_gethandle().

No functional change intended.

MFC after: ???

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

zlei created this revision.Jun 26 2024, 8:58 AM

Herald added a reviewer: andrew. · View Herald TranscriptJun 26 2024, 8:58 AM

Herald added a reviewer: shurd. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a reviewer: iflib. · View Herald Transcript

Herald added subscribers: vegeta_tuxpowered.net, donner, melifaro and 3 others. · View Herald Transcript

zlei requested review of this revision.Jun 26 2024, 8:58 AM

Herald added a subscriber: dsl. · View Herald TranscriptJun 26 2024, 8:58 AM

kp accepted this revision as: kp.Jun 26 2024, 9:05 AM

The full diff is quite large ( about 7 megabytes ). See my dev branch https://github.com/gmshake/freebsd-src/tree/main_if_alloc instead, or I can upload the full diff if requested.

sys/dev/bxe/bxe.c
12988	`if_gethandle()` was introduced in change 62d76917b867 . In FreeBSD net stack it is just a thin wrapper around `if_alloc()`. Since 4787572d0580 is a behavior change, I doubt the net stack of Juniper Networks will follow. Can @glebius comment on that ?

In D45740#1043263, @zlei wrote:

The full diff is quite large ( about 7 megabytes ). See my dev branch https://github.com/gmshake/freebsd-src/tree/main_if_alloc instead, or I can upload the full diff if requested.

I'm not from Juniper :) I would guess Juniper is fine with the proposed changes. They care about IfAPI hiding 'struct ifnet' better and better as time goes by, they don't have a requirement for the API to be never ever changing. I'll add Stephen to reviewers to correct me.

Looks good. I can't answer the wrapper question definitively, but I suspect it will be fine.

glebius accepted this revision as: glebius.Jun 26 2024, 4:05 PM

glebius added a reviewer: stevek.

In D45740#1043372, @glebius wrote:

In D45740#1043263, @zlei wrote:

The full diff is quite large ( about 7 megabytes ). See my dev branch https://github.com/gmshake/freebsd-src/tree/main_if_alloc instead, or I can upload the full diff if requested.

I'm not from Juniper :) I would guess Juniper is fine with the proposed changes. They care about IfAPI hiding 'struct ifnet' better and better as time goes by, they don't have a requirement for the API to be never ever changing. I'll add Stephen to reviewers to correct me.

Yes, this change is fine.

zlei added a commit: rGaa3860851b9f: net: Remove unneeded NULL check for the allocated ifnet.Jun 29 2024, 11:28 AM

Landed as aa3860851b9f but it seems Phabricator got fooled.

This revision was not accepted when it landed; it landed in state Needs Review.Jul 1 2024, 5:01 PM

Closed by commit rGaa3860851b9f: net: Remove unneeded NULL check for the allocated ifnet (authored by zlei). · Explain Why

This revision was automatically updated to reflect the committed changes.

zlei added a commit: rG6b1f530935c5: net: Remove unneeded NULL check for the allocated ifnet.Jul 15 2024, 5:22 PM

zlei mentioned this in D45852: Stop checking for failures from malloc(M_WAITOK).Jul 26 2024, 6:24 PM

zlei added a commit: rGf500e5c6c99b: net: Remove unneeded NULL check for the allocated ifnet.Oct 9 2024, 11:34 PM

Revision Contents
Changeset List

Path

Size

sys/

arm/

allwinner/

5 lines

ti/

cpsw/

5 lines

dev/

ae/

6 lines

age/

6 lines

alc/

6 lines

ale/

6 lines

altera/

atse/

5 lines

axgbe/

5 lines

bce/

6 lines

bfe/

5 lines

bge/

5 lines

bxe/

5 lines

cadence/

5 lines

cas/

2 lines

cxgb/

5 lines

cxgbe/

4 lines

5 lines

dc/

5 lines

dpaa/

6 lines

dpaa2/

5 lines

ena/

4 lines

et/

5 lines

etherswitch/

ar40xx/

8 lines

arswitch/

6 lines

e6000sw/

2 lines

6 lines

felix/

3 lines

infineon/

6 lines

ip17x/

6 lines

micrel/

6 lines

mtkswitch/

6 lines

rtl8366/

6 lines

ukswitch/

6 lines

firewire/

4 lines

2 lines

fxp/

5 lines

gem/

2 lines

gve/

5 lines

iicbus/

2 lines

jme/

6 lines

le/

2 lines

lge/

5 lines

liquidio/

5 lines

mana/

5 lines

mge/

6 lines

mlx4/

mlx4_en/

mlx4_en_netdev.c

5 lines

mlx5/

mlx5_en/

6 lines

msk/

5 lines

mxge/

6 lines

my/

6 lines

neta/

5 lines

netmap/

6 lines

netmap_freebsd.c

4 lines

nfe/

5 lines

nge/

5 lines

ntb/

if_ntb/

4 lines

oce/

2 lines

ppbus/

4 lines

qlnx/

qlnxe/

4 lines

qlxgb/

3 lines

qlxgbe/

4 lines

qlxge/

4 lines

re/

5 lines

rl/

5 lines

sbni/

2 lines

sfxge/

7 lines

sge/

5 lines

sis/

5 lines

sk/

5 lines

smc/

4 lines

ste/

5 lines

stge/

6 lines

ti/

5 lines

tsec/

6 lines

usb/

net/

5 lines

4 lines

5 lines

6 lines

vge/

6 lines

virtio/

network/

16 lines

vnic/

5 lines

4 lines

vr/

5 lines

vte/

6 lines

xilinx/

5 lines

xl/

5 lines

net/

4 lines

5 lines

5 lines

4 lines

11 lines

4 lines

3 lines

5 lines

3 lines

8 lines

5 lines

4 lines

net80211/

4 lines

netgraph/

5 lines

4 lines

netpfil/

ipfw/

4 lines

pf/

3 lines

4 lines

ofed/

drivers/

infiniband/

ulp/

ipoib/

4 lines

Diff 140262

sys/arm/allwinner/if_emac.c

Loading...

sys/arm/ti/cpsw/if_cpsw.c

Loading...

sys/dev/ae/if_ae.c

Loading...

sys/dev/age/if_age.c

Loading...

sys/dev/alc/if_alc.c

Loading...

sys/dev/ale/if_ale.c

Loading...

sys/dev/altera/atse/if_atse.c

Loading...

sys/dev/axgbe/if_axgbe.c

Loading...

sys/dev/bce/if_bce.c

Loading...

sys/dev/bfe/if_bfe.c

Loading...

sys/dev/bge/if_bge.c

Loading...

sys/dev/bxe/bxe.c

Loading...

sys/dev/cadence/if_cgem.c

Loading...

sys/dev/cas/if_cas.c

Loading...

sys/dev/cxgb/cxgb_main.c

Loading...

sys/dev/cxgbe/t4_main.c

Loading...

sys/dev/cxgbe/t4_tracer.c

Loading...

sys/dev/dc/if_dc.c

Loading...

sys/dev/dpaa/if_dtsec.c

Loading...

sys/dev/dpaa2/dpaa2_ni.c

Loading...

sys/dev/ena/ena.c

Loading...

sys/dev/et/if_et.c

Loading...

sys/dev/etherswitch/ar40xx/ar40xx_phy.c

Loading...

sys/dev/etherswitch/arswitch/arswitch.c

Loading...

sys/dev/etherswitch/e6000sw/e6000sw.c

Loading...

sys/dev/etherswitch/e6000sw/e6060sw.c

Loading...

sys/dev/etherswitch/felix/felix.c

Loading...

sys/dev/etherswitch/infineon/adm6996fc.c

Loading...

sys/dev/etherswitch/ip17x/ip17x.c

Loading...

sys/dev/etherswitch/micrel/ksz8995ma.c

Loading...

sys/dev/etherswitch/mtkswitch/mtkswitch.c

Loading...

sys/dev/etherswitch/rtl8366/rtl8366rb.c

Loading...

sys/dev/etherswitch/ukswitch/ukswitch.c

Loading...

sys/dev/firewire/if_fwe.c

Loading...

sys/dev/firewire/if_fwip.c

Loading...

sys/dev/fxp/if_fxp.c

Loading...

sys/dev/gem/if_gem.c

Loading...

sys/dev/gve/gve_main.c

Loading...

sys/dev/iicbus/if_ic.c

Loading...

sys/dev/jme/if_jme.c

Loading...

sys/dev/le/lance.c

Loading...

sys/dev/lge/if_lge.c

Loading...

sys/dev/liquidio/lio_main.c

Loading...

sys/dev/mana/mana_en.c

Loading...

sys/dev/mge/if_mge.c

Loading...

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c

Loading...

sys/dev/mlx5/mlx5_en/mlx5_en_main.c

Loading...

sys/dev/msk/if_msk.c

Loading...

sys/dev/mxge/if_mxge.c

Loading...

sys/dev/my/if_my.c

Loading...

sys/dev/neta/if_mvneta.c

Loading...

sys/dev/netmap/if_ptnet.c

Loading...

sys/dev/netmap/netmap_freebsd.c

Loading...

sys/dev/nfe/if_nfe.c

Loading...

sys/dev/nge/if_nge.c

Loading...

sys/dev/ntb/if_ntb/if_ntb.c

Loading...

sys/dev/oce/oce_if.c

Loading...

sys/dev/ppbus/if_plip.c

Loading...

sys/dev/qlnx/qlnxe/qlnx_os.c

Loading...

sys/dev/qlxgb/qla_os.c

Loading...

sys/dev/qlxgbe/ql_os.c

Loading...

sys/dev/qlxge/qls_os.c

Loading...

sys/dev/re/if_re.c

Loading...

sys/dev/rl/if_rl.c

Loading...

sys/dev/sbni/if_sbni.c

Loading...

sys/dev/sfxge/sfxge.c

Loading...

sys/dev/sge/if_sge.c

Loading...

sys/dev/sis/if_sis.c

Loading...

sys/dev/sk/if_sk.c

Loading...

sys/dev/smc/if_smc.c

Loading...

sys/dev/ste/if_ste.c

Loading...

sys/dev/stge/if_stge.c

Loading...

sys/dev/ti/if_ti.c

Loading...

sys/dev/tsec/if_tsec.c

Loading...

sys/dev/usb/net/if_usie.c

Loading...

sys/dev/usb/net/uhso.c

Loading...

sys/dev/usb/net/usb_ethernet.c

Loading...

sys/dev/usb/usb_pf.c

Loading...

sys/dev/vge/if_vge.c

Loading...

sys/dev/virtio/network/if_vtnet.c

Loading...

sys/dev/vnic/nicvf_main.c

Loading...

sys/dev/vnic/thunder_mdio.c

Loading...

sys/dev/vr/if_vr.c

Loading...

sys/dev/vte/if_vte.c

Loading...

sys/dev/xilinx/if_xae.c

Loading...

sys/dev/xl/if_xl.c

Loading...

sys/net/if_bridge.c

Loading...

sys/net/if_disc.c

Loading...

sys/net/if_edsc.c

Loading...

sys/net/if_enc.c

Loading...

sys/net/if_epair.c

Loading...

sys/net/if_lagg.c

Loading...

sys/net/if_loop.c

Loading...

sys/net/if_stf.c

Loading...

sys/net/if_tuntap.c

Loading...

sys/net/if_vlan.c

Loading...

sys/net/if_vxlan.c

Loading...

sys/net/iflib.c

Loading...

sys/net80211/ieee80211.c

Loading...

sys/netgraph/ng_eiface.c

Loading...

sys/netgraph/ng_iface.c

Loading...

sys/netpfil/ipfw/ip_fw_bpf.c

Loading...

sys/netpfil/pf/if_pflog.c

Loading...

sys/netpfil/pf/if_pfsync.c

Loading...

sys/ofed/drivers/infiniband/ulp/ipoib/ipoib_main.c

Loading...