User Details
User Details
- User Since
- Apr 28 2023, 12:47 AM (54 w, 4 d)
Sep 6 2023
Sep 6 2023
shailend_google.com added inline comments to D41754: gve: Make LRO work for jumbo packets.
shailend_google.com updated the diff for D41754: gve: Make LRO work for jumbo packets.
Removed the spurious alignment
shailend_google.com requested review of D41754: gve: Make LRO work for jumbo packets.
Aug 1 2023
Aug 1 2023
shailend_google.com requested review of D41281: gve: Simplify tx loop over br.
Jul 26 2023
Jul 26 2023
shailend_google.com requested review of D41189: gve: Fix Tx tcpdump panic.
Jun 1 2023
Jun 1 2023
shailend_google.com added inline comments to D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
- Use __predict_false in the MEXTADD callback
- Read page ref count with atomic_load_int
- A bunch of style corrections
- Switch to MIN from sys/params.h
May 31 2023
May 31 2023
shailend_google.com added inline comments to D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
- Account for interface leaving before all Rx mbufs are freed
- Assert that all packet fragments fit in a cluster mbuf
- Have a consistent continuation-line style
May 24 2023
May 24 2023
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
- Do not assume ipv4 if not ipv6
- Explicitly declare lack of support for VLAN
- Replace custom defines of Static_assert with native calls
- Switch to a per-interface lock
May 12 2023
May 12 2023
shailend_google.com added a comment to D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
Could you please elaborate a bit more? How exactly does iflib make this hard to implement?
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
- Fix an ipv6 Tx bug
- Remove all uses of linuxkpi
- Stop checking for failure of malloc when WAITOK is supplied
- Hide all the happy-path logging behind bootverbose
- Make few style corrections and typo fixes
- Introduce a couple of new sysctl counters
May 1 2023
May 1 2023
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
Make few manpage changes and restrict build to x86 and arm64
Apr 28 2023
Apr 28 2023