Page MenuHomeFreeBSD

shailend_google.com (Shailend Chand)
User

Projects

User does not belong to any projects.

User Details

User Since
Apr 28 2023, 12:47 AM (94 w, 1 d)

Recent Activity

Nov 6 2024

shailend_google.com added a comment to D46690: gve: Add DQO RDA support.

{F101963052}

I did some build testing and found that a no-INET6 kernel fails to build. The patch here fixes it for me - if it's acceptable to you I can squash that into the larger patch.

{F101964585}

Thinking about it a bit more, I think this version is better, but it needs some testing.

I'm unable to view the patch at https://reviews.freebsd.org/F101964585, maybe I need to look someplace else?

Hmm, I don't know why. Here it is on github: https://github.com/markjdb/freebsd/commit/522bcbf707a649c48ae4423c08ed769ffda1cf76

Nov 6 2024, 12:27 AM

Nov 5 2024

shailend_google.com added a comment to D46690: gve: Add DQO RDA support.

{F101963052}

I did some build testing and found that a no-INET6 kernel fails to build. The patch here fixes it for me - if it's acceptable to you I can squash that into the larger patch.

{F101964585}

Thinking about it a bit more, I think this version is better, but it needs some testing.

Nov 5 2024, 10:55 PM
shailend_google.com updated the diff for D47138: gve: Fix TX livelock.

Only a rebase

Nov 5 2024, 5:33 PM
shailend_google.com updated the diff for D46691: gve: Add DQO QPL support.

Add a couple of comments suggested by Mark

Nov 5 2024, 5:33 PM

Nov 4 2024

shailend_google.com added inline comments to D47138: gve: Fix TX livelock.
Nov 4 2024, 5:16 PM
shailend_google.com updated the diff for D47138: gve: Fix TX livelock.

Switch to a boolean stopped
Switch to atomic_thread_fence_seq_cst

Nov 4 2024, 5:15 PM
shailend_google.com updated the diff for D46691: gve: Add DQO QPL support.

Only a rebase

Nov 4 2024, 5:15 PM
shailend_google.com updated the diff for D46690: gve: Add DQO RDA support.

Add a KASSERT instead of an explicit check

Nov 4 2024, 5:14 PM

Oct 30 2024

shailend_google.com added inline comments to D47138: gve: Fix TX livelock.
Oct 30 2024, 9:12 PM
shailend_google.com added a comment to D46691: gve: Add DQO QPL support.

This is similar to GQI_QPL in that the NIC only recognizes a fixed set of pre-negotiated pages (QPL: queue page list) as valid buffers. So in Tx, every output mbuf's contents are copied into the QPL. In GQI, the QPL pages are mapped into a contiguous memory region ("fifo"). This is not possible in DQO_QPL because the completions for Tx packets might arrive out of order. So page fragments used for each packet are explicitly marked as "in use" (pending_pkt) and reaped again when a completion arrives.

Oct 30 2024, 9:11 PM
shailend_google.com added a comment to D46690: gve: Add DQO RDA support.

Thanks for reviewing!

Oct 30 2024, 9:10 PM
shailend_google.com updated the diff for D47138: gve: Fix TX livelock.

Address Mark's review comments

Oct 30 2024, 9:10 PM
shailend_google.com updated the diff for D46691: gve: Add DQO QPL support.

Address Mark's review comments

Oct 30 2024, 9:09 PM
shailend_google.com updated the diff for D46690: gve: Add DQO RDA support.

Address Mark's comments

Oct 30 2024, 9:08 PM

Oct 15 2024

shailend_google.com updated the summary of D47138: gve: Fix TX livelock.
Oct 15 2024, 8:54 PM
shailend_google.com requested review of D47138: gve: Fix TX livelock.
Oct 15 2024, 8:46 PM
shailend_google.com updated the diff for D46691: gve: Add DQO QPL support.

Removed the RFC prefix in the commit msg
Rebased onto parent

Oct 15 2024, 8:41 PM
shailend_google.com updated the diff for D46690: gve: Add DQO RDA support.

Removed the RFC prefix in the commit msg
Added a couple of sysctls
Updated man page

Oct 15 2024, 8:39 PM
shailend_google.com retitled D46691: gve: Add DQO QPL support from [RFC] gve: Add DQO QPL support to gve: Add DQO QPL support.
Oct 15 2024, 8:25 PM
shailend_google.com retitled D46690: gve: Add DQO RDA support from [RFC] gve: Add DQO RDA support to gve: Add DQO RDA support.
Oct 15 2024, 8:25 PM

Sep 17 2024

shailend_google.com requested review of D46691: gve: Add DQO QPL support.
Sep 17 2024, 6:54 PM
shailend_google.com requested review of D46690: gve: Add DQO RDA support.
Sep 17 2024, 6:54 PM

Jun 4 2024

shailend_google.com requested review of D45489: gve: Make gve_free_qpls idempotent.
Jun 4 2024, 8:44 PM

Sep 6 2023

shailend_google.com added inline comments to D41754: gve: Make LRO work for jumbo packets.
Sep 6 2023, 6:38 PM
shailend_google.com updated the diff for D41754: gve: Make LRO work for jumbo packets.

Removed the spurious alignment

Sep 6 2023, 6:37 PM
shailend_google.com requested review of D41754: gve: Make LRO work for jumbo packets.
Sep 6 2023, 1:13 AM

Aug 1 2023

shailend_google.com requested review of D41281: gve: Simplify tx loop over br.
Aug 1 2023, 5:28 PM

Jul 26 2023

shailend_google.com requested review of D41189: gve: Fix Tx tcpdump panic.
Jul 26 2023, 12:37 AM

Jun 1 2023

shailend_google.com added inline comments to D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
Jun 1 2023, 11:39 PM
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
  • Use __predict_false in the MEXTADD callback
  • Read page ref count with atomic_load_int
  • A bunch of style corrections
  • Switch to MIN from sys/params.h
Jun 1 2023, 11:38 PM

May 31 2023

shailend_google.com added inline comments to D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
May 31 2023, 7:12 PM
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
  • Account for interface leaving before all Rx mbufs are freed
  • Assert that all packet fragments fit in a cluster mbuf
  • Have a consistent continuation-line style
May 31 2023, 7:11 PM

May 24 2023

shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
  • Do not assume ipv4 if not ipv6
  • Explicitly declare lack of support for VLAN
  • Replace custom defines of Static_assert with native calls
  • Switch to a per-interface lock
May 24 2023, 12:01 AM

May 12 2023

shailend_google.com added a comment to D39873: Add gve, the driver for Google Virtual NIC (gVNIC).

Could you please elaborate a bit more? How exactly does iflib make this hard to implement?

May 12 2023, 8:55 PM
shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
  • Fix an ipv6 Tx bug
  • Remove all uses of linuxkpi
  • Stop checking for failure of malloc when WAITOK is supplied
  • Hide all the happy-path logging behind bootverbose
  • Make few style corrections and typo fixes
  • Introduce a couple of new sysctl counters
May 12 2023, 8:54 PM

May 1 2023

shailend_google.com updated the diff for D39873: Add gve, the driver for Google Virtual NIC (gVNIC).

Make few manpage changes and restrict build to x86 and arm64

May 1 2023, 5:51 PM

Apr 28 2023

shailend_google.com requested review of D39873: Add gve, the driver for Google Virtual NIC (gVNIC).
Apr 28 2023, 4:42 PM