Page MenuHomeFreeBSD

gve: Fix Tx tcpdump panic
ClosedPublic

Authored by shailend_google.com on Jul 26 2023, 12:37 AM.
Tags
None
Referenced Files
F156928289: D41189.diff
Sun, May 17, 10:26 AM
F156928270: D41189.diff
Sun, May 17, 10:26 AM
Unknown Object (File)
Mon, May 11, 5:40 PM
Unknown Object (File)
Mon, May 11, 5:40 PM
Unknown Object (File)
Mon, May 11, 12:15 AM
Unknown Object (File)
Sun, May 10, 6:54 PM
Unknown Object (File)
Tue, Apr 28, 4:07 PM
Unknown Object (File)
Tue, Apr 28, 4:03 PM
Subscribers
None

Details

Summary

Ringing the doorbell before making the BPF call can result in the
mbuf being freed before the BPF call.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

shailend_google.com created this revision.
sys/dev/gve/gve_tx.c
709

BTW, this usage of drbr looks like it could be a bit simpler:

while ((if_getdrvflags(ifp) & IFF_DRV_RUNNING) != 0 && (m = drbr_peek()) != NULL) {
    if (gve_xmit(tx, mbuf) != 0) {
        ...
    }
    drbr_advance(ifp, tx->br);
    ...
}

Right now we're needlessly checking for an empty ring in drbr_peek() after having already done so with drbr_empty().

This revision is now accepted and ready to land.Jul 26 2023, 2:33 PM
This revision was automatically updated to reflect the committed changes.