Differential D38338

bhyve: add cmdline option for user defined fw_cfg items
ClosedPublic
Actions

Authored by corvink on Feb 1 2023, 11:11 AM.

Tags

None

Referenced Files

	F171742178: D38338.diff
	Sun, Sep 13, 5:02 AM

	F171736917: D38338.diff
	Sun, Sep 13, 3:56 AM

	Unknown Object (File)
	Sat, Sep 12, 9:49 AM

	Unknown Object (File)
	Thu, Sep 10, 11:02 PM

	Unknown Object (File)
	Thu, Sep 10, 12:36 PM

	Unknown Object (File)
	Mon, Sep 7, 11:30 PM

	Unknown Object (File)
	Mon, Sep 7, 2:47 AM

	Unknown Object (File)
	Mon, Sep 7, 2:29 AM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

Commits

rGb1fffed683ab: bhyve: add cmdline option for user defined fw_cfg items
rGca14781c8170: bhyve: add cmdline option for user defined fw_cfg items

Summary

Some guest allow to configure themself by fw_cfg. E.g. Fedora CoreOs can
be provisioned by adding a JSON file as fw_cfg item.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 51341
Build 48232: arc lint + arc unit

Event Timeline

corvink created this revision.Feb 1 2023, 11:11 AM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 1 2023, 11:11 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

corvink requested review of this revision.Feb 1 2023, 11:11 AM

Harbormaster completed remote builds in B49410: Diff 116194.Feb 1 2023, 11:11 AM

corvink mentioned this in D31578: bhyve: add support for QEMU's fwcfg.Feb 1 2023, 11:15 AM

corvink added a parent revision: D38337: bhyve: add cmdline option to enable qemu's fwcfg.

rebase

Harbormaster completed remote builds in B49595: Diff 116685.Feb 7 2023, 7:45 AM

@markj @jhb Any complains about this? I'd like to get this merged for 14.0.

fix minor style issues

Harbormaster completed remote builds in B51151: Diff 120918.Apr 24 2023, 10:38 AM

HEADS UP. I'm going to commit this tomorrow if noone complains.

markj added inline comments.Apr 24 2023, 3:34 PM

usr.sbin/bhyve/qemu_fwcfg.c
407
584	Why not just use fstat()?
595	This is missing handling of errors and short reads.

fix style issues
make use of fstat
handle short reads

Harbormaster completed remote builds in B51341: Diff 121571.May 5 2023, 1:31 PM

corvink marked 3 inline comments as done.May 5 2023, 1:31 PM

@jhb @markj Any additional feedback?

A few suggestions, but looks ok to me otherwise.

usr.sbin/bhyve/bhyverun.c
1294	EX_USAGE?
usr.sbin/bhyve/qemu_fwcfg.c
604–606

This revision is now accepted and ready to land.May 9 2023, 8:30 PM

markj added inline comments.May 10 2023, 5:41 PM

usr.sbin/bhyve/qemu_fwcfg.c
567
583	This can be warn() instead of warnx().
585	close() would generally clobber errno. So we either need to save/restore it, or just return -1.
601	Same comment about errno. Also a short read is not necessarily an error.

Closed by commit rGca14781c8170: bhyve: add cmdline option for user defined fw_cfg items (authored by corvink). · Explain WhyMay 11 2023, 12:21 PM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGca14781c8170: bhyve: add cmdline option for user defined fw_cfg items.

corvink added a commit: rGb1fffed683ab: bhyve: add cmdline option for user defined fw_cfg items.Aug 18 2023, 7:29 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

19 lines

9 lines

1 line

144 lines

Diff 121571

usr.sbin/bhyve/bhyve.8

Loading...

usr.sbin/bhyve/bhyverun.c

Loading...

usr.sbin/bhyve/qemu_fwcfg.h

Loading...

usr.sbin/bhyve/qemu_fwcfg.c

Loading...