Page MenuHomeFreeBSD
Differential D38332

bhyve: add emulation for the qemu fwcfg selector port
ClosedPublic
Actions

Authored by corvink on Feb 1 2023, 11:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Dec 20 2023, 6:31 AM
Unknown Object (File)
Dec 11 2023, 12:53 AM
Unknown Object (File)
Nov 14 2023, 4:26 PM
Unknown Object (File)
Nov 4 2023, 8:07 PM
Unknown Object (File)
Nov 3 2023, 2:54 PM
Unknown Object (File)
Nov 3 2023, 2:49 PM
Unknown Object (File)
Nov 3 2023, 2:38 PM
Unknown Object (File)
Oct 10 2023, 8:30 PM
View All 32 Files
Subscribers
bcran
imp
rew
rgrimes

Details

Reviewers
jhb
markj
Group Reviewers
bhyve
Commits
rGbd8366500e15: bhyve: add emulation for the qemu fwcfg selector port
rG151d8131a817: bhyve: add emulation for the qemu fwcfg selector port
Summary

The selector port is used to select the desired fwcfg item.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

corvink created this revision.Feb 1 2023, 11:10 AM
Herald added a reviewer: bhyve. · View Herald TranscriptFeb 1 2023, 11:10 AM
Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript
corvink requested review of this revision.Feb 1 2023, 11:10 AM
Harbormaster completed remote builds in B49404: Diff 116188.Feb 1 2023, 11:10 AM
corvink added a parent revision: D38331: bhyve: add basic qemu fwcfg implementation.Feb 1 2023, 11:14 AM
corvink added a child revision: D38333: bhyve: add emulation for qemu's fwcfg data port.
corvink mentioned this in D31578: bhyve: add support for QEMU's fwcfg.
markj accepted this revision as: markj.Feb 2 2023, 2:20 PM
This revision is now accepted and ready to land.Feb 2 2023, 2:20 PM
rew added a subscriber: rew.Feb 6 2023, 10:20 PM
rew added inline comments.
usr.sbin/bhyve/qemu_fwcfg.c
38–54

maybe it'd make sense to comment the macro definition or rename the macro such that it doesn't need a comment.

corvink added inline comments.Feb 7 2023, 7:59 AM
usr.sbin/bhyve/qemu_fwcfg.c
38–54

Your suggestion makes no sense. architecture is a single bit. You can assign a value of QEMU_FWCFG_ARCHITECTURE_GENERIC or QEMU_FWCFG_ARCHITECTURE_SPECIFIC to it. So, the bit width should be 1 and not QEMU_FWCFG_ARCHITECTURE_SPECIFIC.

The comment is added to clarify the meaning of different values for architecture.

rew added inline comments.Feb 7 2023, 6:42 PM
usr.sbin/bhyve/qemu_fwcfg.c
38–54

right, I misread it - still not sure the comment is necessary if the macro names make the meaning apparent...either way, it doesn't really matter.

Closed by commit rG151d8131a817: bhyve: add emulation for the qemu fwcfg selector port (authored by corvink). · Explain WhyFeb 14 2023, 7:29 AM
This revision was automatically updated to reflect the committed changes.
corvink added a commit: rG151d8131a817: bhyve: add emulation for the qemu fwcfg selector port.
corvink added a commit: rGbd8366500e15: bhyve: add emulation for the qemu fwcfg selector port.Feb 28 2023, 10:14 AM

Revision Contents
Changeset List

PathSize
usr.sbin/
bhyve/
39 lines

Diff 117185

View Options

usr.sbin/bhyve/qemu_fwcfg.c

Loading...