Differential D38337

bhyve: add cmdline option to enable qemu's fwcfg
ClosedPublic
Actions

Authored by corvink on Feb 1 2023, 11:11 AM.

Tags

None

Referenced Files

	F156494506: D38337.diff
	Thu, May 14, 2:44 AM

	Unknown Object (File)
	Sun, May 10, 1:42 PM

	Unknown Object (File)
	Tue, May 5, 6:41 PM

	Unknown Object (File)
	Tue, May 5, 6:40 PM

	Unknown Object (File)
	Tue, May 5, 6:37 PM

	Unknown Object (File)
	Tue, May 5, 2:10 PM

	Unknown Object (File)
	Tue, May 5, 1:43 PM

	Unknown Object (File)
	Sun, May 3, 2:05 PM

Subscribers

Details

Reviewers

jhb
markj

Group Reviewers

Commits

rGd468d5dd195f: bhyve: add cmdline option to enable qemu's fwcfg
rGd85147f3d681: bhyve: add cmdline option to enable qemu's fwcfg

Summary

Let the user decide if he wants to use bhyve's fwctl or qemu's fwcfg. He
can set the interface by adding a fwcfg option to bootrom:

-l bootrom,<path/to/rom>,fwcfg=bhyve
-l bootrom,<path/to/rom>,fwcfg=qemu

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

corvink created this revision.Feb 1 2023, 11:11 AM

Herald added a reviewer: bhyve. · View Herald TranscriptFeb 1 2023, 11:11 AM

Herald added subscribers: bcran, rgrimes, imp. · View Herald Transcript

corvink requested review of this revision.Feb 1 2023, 11:11 AM

Harbormaster completed remote builds in B49409: Diff 116193.Feb 1 2023, 11:11 AM

corvink mentioned this in D31578: bhyve: add support for QEMU's fwcfg.Feb 1 2023, 11:15 AM

corvink added a parent revision: D38336: bhyve: add helper for adding fwcfg files.

corvink added a child revision: D38338: bhyve: add cmdline option for user defined fw_cfg items.

do not create acpi tables for fwcfg if it's unused

Harbormaster completed remote builds in B49594: Diff 116684.Feb 7 2023, 7:44 AM

corvink added a child revision: D38438: bhyve: add helper struct for qemus acpi table loader.Feb 8 2023, 2:04 PM

corvink removed a child revision: D38438: bhyve: add helper struct for qemus acpi table loader.

markj added inline comments.Feb 14 2023, 3:19 PM

usr.sbin/bhyve/bhyve.8
204	I think some more elaboration is needed. What is a "fwcfg", what are the valid values, why would someone choose one value over the other?
usr.sbin/bhyve/bhyve_config.5
262
usr.sbin/bhyve/bhyverun.c
1471
1570

explain usage of fwcfg more detailed
fix style issues

Harbormaster completed remote builds in B49799: Diff 117285.Feb 15 2023, 11:10 AM

corvink marked 3 inline comments as done.Feb 15 2023, 11:10 AM

markj added inline comments.Feb 20 2023, 3:54 PM

usr.sbin/bhyve/bhyve.8
528
529	Same below.
532
534
535
536
usr.sbin/bhyve/bhyve_config.5
534
535

fix man page wording

Harbormaster completed remote builds in B50059: Diff 118057.Feb 28 2023, 9:42 AM

corvink marked 9 inline comments as done.Feb 28 2023, 9:43 AM

Looks ok aside from the nits.

usr.sbin/bhyve/bhyve.8
542
543
usr.sbin/bhyve/bhyve_config.5
535

This revision is now accepted and ready to land.Mar 8 2023, 4:20 PM

Closed by commit rGd85147f3d681: bhyve: add cmdline option to enable qemu's fwcfg (authored by corvink). · Explain WhyMar 17 2023, 8:36 AM

This revision was automatically updated to reflect the committed changes.

corvink added a commit: rGd85147f3d681: bhyve: add cmdline option to enable qemu's fwcfg.

corvink added a commit: rGd468d5dd195f: bhyve: add cmdline option to enable qemu's fwcfg.Mar 27 2023, 6:40 AM

Revision Contents
Changeset List

Path

Size

usr.sbin/

bhyve/

1 line

29 lines

8 lines

16 lines

1 line

18 lines

71 lines

Diff 118970

usr.sbin/bhyve/Makefile

Loading...

usr.sbin/bhyve/bhyve.8

Loading...

usr.sbin/bhyve/bhyve_config.5

Loading...

usr.sbin/bhyve/bhyverun.c

Loading...

usr.sbin/bhyve/pci_lpc.h

Loading...

usr.sbin/bhyve/pci_lpc.c

Loading...

usr.sbin/bhyve/qemu_fwcfg.c

Loading...