Page MenuHomeFreeBSD

bhyve: add common fwcfg items
ClosedPublic

Authored by corvink on Feb 1 2023, 11:10 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 17, 4:29 PM
Unknown Object (File)
Sun, Apr 7, 2:08 PM
Unknown Object (File)
Mar 18 2024, 4:00 PM
Unknown Object (File)
Mar 18 2024, 4:00 PM
Unknown Object (File)
Mar 18 2024, 4:00 PM
Unknown Object (File)
Mar 18 2024, 3:59 PM
Unknown Object (File)
Mar 18 2024, 3:46 PM
Unknown Object (File)
Dec 20 2023, 4:19 AM
Subscribers

Details

Summary

Qemu defines some common fwcfg items. We don't need to support all of
them. Only a subset needs to be present for fwcfg to work properly.

  • signature The signature is used by the guest to check if qemu's fwcfg is available or not.
  • id The id is used by the guest to check which features are supported by the fwcfg implementation of the hypervisor.
  • file_dir The file dir reports all fwcfg items which don't have a fixed index. These are mostly user defined fwcfg items.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

usr.sbin/bhyve/qemu_fwcfg.c
188
195

Why a negative value?

203

This line is too long, missing parens around the return value.

markj added inline comments.
usr.sbin/bhyve/qemu_fwcfg.c
198

This style of commenting is useless IMHO. It would be much more useful to, for example, describe the information that is encoded in this directory structure.

This revision is now accepted and ready to land.Feb 14 2023, 2:55 PM
This revision was automatically updated to reflect the committed changes.