Page MenuHomeFreeBSD
Differential D36303

Implement AccECN option (w/ early assigned option number)
Needs ReviewPublic
Actions

Authored by rscheff on Aug 23 2022, 9:10 AM.
Tags
None
Referenced Files
F149296865: D36303.id112714.diff
Mon, Mar 23, 1:51 PM
F149215115: D36303.id112714.diff
Mon, Mar 23, 1:37 AM
F149179808: D36303.id112714.diff
Sun, Mar 22, 7:37 PM
Unknown Object (File)
Sun, Mar 22, 7:40 AM
Unknown Object (File)
Sat, Mar 21, 6:50 AM
Unknown Object (File)
Sat, Mar 21, 3:15 AM
Unknown Object (File)
Mon, Mar 16, 1:29 PM
Unknown Object (File)
Wed, Mar 11, 10:11 AM
View All Files
Subscribers
gbe
imp
melifaro

Details

Reviewers
tuexen
jtl
thj
rrs
glebius
Group Reviewers
transport
Summary

This Diff builds upon D21011. A simplistic reflector for
the received CE, ECT1 and ECT0 marked data bytes in the
AccECN TCP option - which is sent on every ACK, in full.
Only when space is needed for SACK, an abbreviated option
is constructed and sent (if possible).

Potential enhancements: Track which counters changed, and
send only changed counters repeatedly (e.g. 3 times at least)

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 47066
Build 43955: arc lint + arc unit

Event Timeline

rscheff created this revision.Aug 23 2022, 9:10 AM
Herald added a reviewer: transport. · View Herald TranscriptAug 23 2022, 9:10 AM
Herald added subscribers: melifaro, imp. · View Herald Transcript
rscheff requested review of this revision.Aug 23 2022, 9:10 AM
Harbormaster completed remote builds in B47066: Diff 109702.Aug 23 2022, 9:10 AM
rscheff updated this revision to Diff 110016.Aug 31 2022, 1:52 PM

rebase to main

Harbormaster completed remote builds in B47201: Diff 110016.Aug 31 2022, 1:52 PM
rscheff added a comment.Sep 8 2022, 3:09 PM

validating this diff against accecn packetdrill scripts from Linux (Ilpo). Once done, will bring this up again.

rscheff updated this revision to Diff 111278.Sep 30 2022, 3:44 PM
  • move ecn sysctls to tcp_ecn.c
  • go with AccECN options from a compile time option to a global setting
  • document the new sysctl option
  • remove outdated comment
Harbormaster completed remote builds in B47660: Diff 111278.Sep 30 2022, 3:44 PM
rscheff updated this revision to Diff 111633.Oct 11 2022, 8:45 AM
  • rebase to main
Harbormaster completed remote builds in B47772: Diff 111633.Oct 11 2022, 8:45 AM
rscheff updated this revision to Diff 111807.Oct 14 2022, 1:39 PM
  • ensure control packets have accecn opt, if enabled
Harbormaster completed remote builds in B47838: Diff 111807.Oct 14 2022, 1:39 PM
gbe added a subscriber: gbe.Oct 26 2022, 8:46 PM
rscheff updated this revision to Diff 112714.Nov 7 2022, 10:18 AM
  • move ecn sysctls to tcp_ecn.c
  • go with AccECN options from a compile time option to a global setting
  • document the new sysctl option
  • remove outdated comment
  • add logging, and make syncache response honor most recent incoming SYN fields
  • add logging
  • more logging
  • ensure control packets have accecn opt, if enabled
  • fix packt_this_ack bug
  • bump man date
  • received accecn counter into tcpinfo
  • add more tcpinfo counters
  • make accecn option counters a struct within tcpcb, which can also be locally allocated (syncache, prior of tcpcb)
  • initialize to_ae properly
  • reference properly to counters
  • bump man page date
  • remove all logging
Harbormaster completed remote builds in B48203: Diff 112714.Nov 7 2022, 10:18 AM
rscheff updated this revision to Diff 123335.Jun 16 2023, 12:34 PM
  • add ntoh24 and hton24 to improve readability
  • compact AccECN opt decoding
  • straighten option output path
Harbormaster completed remote builds in B52102: Diff 123335.Jun 16 2023, 12:34 PM
rscheff updated this revision to Diff 123352.Jun 16 2023, 6:04 PM
  • use temp variable to improve readability
Harbormaster completed remote builds in B52108: Diff 123352.Jun 16 2023, 6:04 PM
rscheff updated this revision to Diff 132863.Jan 17 2024, 8:09 AM
  • rebase to main
Harbormaster completed remote builds in B55461: Diff 132863.Jan 17 2024, 8:09 AM
rscheff updated this revision to Diff 134552.Feb 18 2024, 10:27 AM
  • rebase main
Harbormaster completed remote builds in B56082: Diff 134552.Feb 18 2024, 10:27 AM

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
1 line
netinet/
6 lines
4 lines
18 lines
5 lines
167 lines
10 lines
28 lines
33 lines

Diff 109702

View Options

sys/conf/config.mk

Loading...
View Options

sys/conf/options

Loading...
View Options

sys/netinet/tcp.h

Loading...
View Options

sys/netinet/tcp_ecn.h

Loading...
View Options

sys/netinet/tcp_ecn.c

Loading...
View Options

sys/netinet/tcp_input.c

Loading...
View Options

sys/netinet/tcp_output.c

Loading...
View Options

sys/netinet/tcp_subr.c

Loading...
View Options

sys/netinet/tcp_syncache.c

Loading...
View Options

sys/netinet/tcp_var.h

Loading...