Page MenuHomeFreeBSD

sound: Retire SND_OLDSTEREO
ClosedPublic

Authored by christos on Thu, Mar 19, 1:27 PM.
Tags
None
Referenced Files
F150391506: D55933.id174214.diff
Tue, Mar 31, 7:54 PM
Unknown Object (File)
Mon, Mar 30, 5:46 AM
Unknown Object (File)
Mon, Mar 30, 3:20 AM
Unknown Object (File)
Thu, Mar 26, 2:25 PM
Unknown Object (File)
Thu, Mar 26, 2:42 AM
Unknown Object (File)
Wed, Mar 25, 9:32 AM
Unknown Object (File)
Wed, Mar 25, 6:57 AM
Unknown Object (File)
Tue, Mar 24, 10:50 AM
Subscribers

Details

Summary

This is a legacy option and does not serve a good purpose anymore.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/dev/sound/pcm/matrix.h
33

How is this "unused"?

sys/dev/sound/pcm/matrix.h
33

It never gets defined, so this condition is always true.

sys/dev/sound/pcm/matrix.h
33

It's a kernel option, right? So a user might define it by configuring "options SND_OLDSTEREO" in their kernel config.

If you want to remove the option, then fine, but "unused" is not correct I think.

christos retitled this revision from sound: Retire unused SND_OLDSTEREO to sound: Retire SND_OLDSTEREO.Mon, Mar 23, 12:48 PM
christos edited the summary of this revision. (Show Details)
sys/dev/sound/pcm/matrix.h
33

I forgot about this. But still I'm pretty sure no one is using this option.

This revision is now accepted and ready to land.Mon, Mar 23, 1:58 PM
This revision was automatically updated to reflect the committed changes.