Differential D55933

sound: Retire SND_OLDSTEREO
ClosedPublic
Actions

Authored by christos on Thu, Mar 19, 1:27 PM.

Tags

None

Referenced Files

	F150391506: D55933.id174214.diff
	Tue, Mar 31, 7:54 PM

	Unknown Object (File)
	Mon, Mar 30, 5:46 AM

	Unknown Object (File)
	Mon, Mar 30, 3:20 AM

	Unknown Object (File)
	Thu, Mar 26, 2:25 PM

	Unknown Object (File)
	Thu, Mar 26, 2:42 AM

	Unknown Object (File)
	Wed, Mar 25, 9:32 AM

	Unknown Object (File)
	Wed, Mar 25, 6:57 AM

	Unknown Object (File)
	Tue, Mar 24, 10:50 AM

Subscribers

Details

Reviewers

markj
emaste

Commits

rGea4182876ac5: sound: Retire SND_OLDSTEREO
rGbf0e5d987ecd: sound: Retire SND_OLDSTEREO

Summary

This is a legacy option and does not serve a good purpose anymore.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Thu, Mar 19, 1:27 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 19, 1:27 PM

christos requested review of this revision.Thu, Mar 19, 1:27 PM

Harbormaster completed remote builds in B71506: Diff 173894.Thu, Mar 19, 1:28 PM

christos added a parent revision: D55932: sound: Retire SND_DEBUG.Thu, Mar 19, 1:28 PM

christos added a child revision: D55934: sound: Retire SND_MULTICHANNEL.

markj added inline comments.Fri, Mar 20, 2:10 AM

sys/dev/sound/pcm/matrix.h
33	How is this "unused"?

christos added inline comments.Fri, Mar 20, 10:28 AM

sys/dev/sound/pcm/matrix.h
33	It never gets defined, so this condition is always true.

markj added inline comments.Sat, Mar 21, 3:25 AM

sys/dev/sound/pcm/matrix.h
33	It's a kernel option, right? So a user might define it by configuring "options SND_OLDSTEREO" in their kernel config. If you want to remove the option, then fine, but "unused" is not correct I think.

christos retitled this revision from sound: Retire unused SND_OLDSTEREO to sound: Retire SND_OLDSTEREO.Mon, Mar 23, 12:48 PM

christos edited the summary of this revision. (Show Details)

christos added inline comments.Mon, Mar 23, 12:50 PM

sys/dev/sound/pcm/matrix.h
33	I forgot about this. But still I'm pretty sure no one is using this option.

markj accepted this revision.Mon, Mar 23, 1:58 PM

This revision is now accepted and ready to land.Mon, Mar 23, 1:58 PM

Closed by commit rGbf0e5d987ecd: sound: Retire SND_OLDSTEREO (authored by christos). · Explain WhyTue, Mar 24, 10:39 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rGbf0e5d987ecd: sound: Retire SND_OLDSTEREO.

christos added a commit: rGea4182876ac5: sound: Retire SND_OLDSTEREO.Tue, Mar 31, 9:55 AM

Revision Contents
Changeset List

Path

Size

sys/

conf/

4 lines

1 line

dev/

sound/

pcm/

3 lines

Diff 174214

sys/conf/NOTES

Loading...

sys/conf/options

Loading...

sys/dev/sound/pcm/matrix.h

Loading...