Differential D55934

sound: Retire SND_MULTICHANNEL
ClosedPublic
Actions

Authored by christos on Thu, Mar 19, 1:28 PM.

Tags

None

Referenced Files

	F149538985: D55934.diff
	Wed, Mar 25, 3:09 AM

	F149495142: D55934.diff
	Tue, Mar 24, 8:28 PM

	F149495134: D55934.diff
	Tue, Mar 24, 8:28 PM

	F149409651: D55934.id173895.diff
	Tue, Mar 24, 6:58 AM

Subscribers

Details

Reviewers

markj
emaste

Commits

rG712bd9b2750a: sound: Retire SND_MULTICHANNEL

Summary

SND_MULTICHANNEL is always defined, so SND_CHN_MAX will also always be

Apart from the fact that there is no other place in the code that

touches SND_MULTICHANNEL, there is also no good reason nowadays to set
SND_CHN_MAX to 2.

Sponsored by: The FreeBSD Foundation
MFC after: 1 week

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

christos created this revision.Thu, Mar 19, 1:28 PM

Herald added a subscriber: imp. · View Herald TranscriptThu, Mar 19, 1:28 PM

christos requested review of this revision.Thu, Mar 19, 1:28 PM

Harbormaster completed remote builds in B71507: Diff 173895.Thu, Mar 19, 1:28 PM

christos added a parent revision: D55933: sound: Retire SND_OLDSTEREO.Thu, Mar 19, 1:28 PM

markj added inline comments.Fri, Mar 20, 2:17 AM

sys/dev/sound/pcm/matrix.h
181	How is this a no-op? Please write commit log messages.

christos added inline comments.Fri, Mar 20, 10:31 AM

sys/dev/sound/pcm/matrix.h
181	You are right. I only didn't write one because I thought it is fairly obvious in this case. SND_MULTICHANNEL is defined in the file above, so this condition is always true since there is no undef for it in the code. That being said, perhaps no-op is not a good word for this.

christos retitled this revision from sound: Retire no-op SND_MULTICHANNEL to sound: Retire SND_MULTICHANNEL.Fri, Mar 20, 10:54 AM

christos edited the summary of this revision. (Show Details)

markj accepted this revision.Sat, Mar 21, 3:27 AM

This revision is now accepted and ready to land.Sat, Mar 21, 3:27 AM

Closed by commit rG712bd9b2750a: sound: Retire SND_MULTICHANNEL (authored by christos). · Explain WhyTue, Mar 24, 10:39 AM

This revision was automatically updated to reflect the committed changes.

christos added a commit: rG712bd9b2750a: sound: Retire SND_MULTICHANNEL.

Revision Contents
Changeset List

Path

Size

sys/

dev/

sound/

pcm/

7 lines

Diff 174215

sys/dev/sound/pcm/matrix.h

Loading...