Page MenuHomeFreeBSD

coredirector - Intel TD/HFI driver - Part3: Add CPU core performance/efficiency score variable to SMP's cpu_group struct.
Needs ReviewPublic

Authored by koinec_yahoo.co.jp on Mar 21 2024, 12:24 PM.
Tags
None
Referenced Files
Unknown Object (File)
May 21 2024, 4:45 AM
Unknown Object (File)
May 13 2024, 1:22 PM
Unknown Object (File)
May 10 2024, 4:47 AM
Unknown Object (File)
May 9 2024, 3:57 PM
Unknown Object (File)
May 9 2024, 11:52 AM
Unknown Object (File)
May 4 2024, 9:57 AM
Unknown Object (File)
May 3 2024, 11:13 PM
Subscribers
None
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

I developed the Intel Thread Director (ITD) / Hardware Feedback Interfce (HFI) device driver to obtain performance/efficiency information for each CPU core, which was implemented to improve the performance of Intel hybrid architecture CPUs. (e.g. Raptor Lake (refresh), Alder Lake, LakeField processors)

This driver simply obtains performance/efficiency information from the CPU and stores it in the "cpu_group" struct data referenced by the ULE scheduler.
However, since the ULE scheduler side is not yet supported, performance/efficiency cannot be improved by installing this driver at this time.

I will try to modify the ULE scheduler side in the future, but I posted this driver first because it can be implemented independently of this driver and it is difficult to modify the ULE scheduler.

There are seven patches, and this is the Part 3.
The ULE scheduler seems to refer to the "cpu_group" structure generated by the SMP code to determine which cores to allocate tasks to.
However, currently it seems that the performance of all cores is treated equally, so in order to be able to change this, I will add the score variable array for each CPU core group to the "cpu_group" structure.

Test Plan

With the remaining patches to be submitted later, I ran the tests listed below.

  • FreeBSD 15-current: Be able to apply patches and build to the latest source tree as of 2024/03/20. After building, restart the OS and be able to start the kernel correctly.
  • FreeBSD 14.0-Release: The source tree can be patched and built. After building, it is possible to load the driver and correctly obtain performance values from the CPU.

Due to my development environment, I developed it on FreeBSD 14.0-RELEASE and ported it to FreeBSD 15-current on a virtual environment.
However, I have also confirmed that the parts related to the code modified this time have hardly changed between 14.0-RELEASE and 15-current.
For this reason, I believe that it will probably work with 15-current, but if you are able to test it, please help confirm that it works.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

koinec_yahoo.co.jp created this revision.

Attach the full context patch file.

Attach the patch file created with the git format-patch command.