Page MenuHomeFreeBSD

intelhfi - Intel TD/HFI driver - Part7: Add kerneldoc's Doxyfile
Needs ReviewPublic

Authored by koinec_yahoo.co.jp on Mar 21 2024, 12:44 PM.
Referenced Files
Unknown Object (File)
Tue, Jan 20, 3:24 AM
Unknown Object (File)
Sun, Jan 18, 6:13 PM
Unknown Object (File)
Sat, Jan 17, 5:11 AM
Unknown Object (File)
Mon, Jan 12, 12:03 PM
Unknown Object (File)
Jan 10 2026, 2:34 PM
Unknown Object (File)
Jan 10 2026, 4:11 AM
Unknown Object (File)
Jan 10 2026, 3:27 AM
Unknown Object (File)
Jan 9 2026, 5:37 PM

Details

Reviewers
None
Group Reviewers
Contributor Reviews (src)
Summary

I developed the Intel Thread Director (ITD) / Hardware Feedback Interfce (HFI) device driver to obtain performance/efficiency information for each CPU core, which was implemented to improve the performance of Intel hybrid architecture CPUs. (e.g. Raptor Lake (refresh), Alder Lake, LakeField processors)

This driver simply obtains performance/efficiency information from the CPU and stores it in the "cpu_group" struct data referenced by the ULE scheduler.
However, since the ULE scheduler side is not yet supported, performance/efficiency cannot be improved by installing this driver at this time.

I will try to modify the ULE scheduler side in the future, but I posted this driver first because it can be implemented independently of this driver and it is difficult to modify the ULE scheduler.

There are seven patches, and this is the Part 7.
This patch adds kerneldoc's Doxyfile.

Test Plan

With the remaining patches to be submitted later, I ran the tests listed below.

  • FreeBSD 15-current: Be able to apply patches.
  • FreeBSD 14.0-Release: The source tree can be patched.

Due to my development environment, I developed it on FreeBSD 14.0-RELEASE and ported it to FreeBSD 15-current on a virtual environment.
However, I have also confirmed that the parts related to the code modified this time have hardly changed between 14.0-RELEASE and 15-current.
For this reason, I believe that it will probably work with 15-current, but if you are able to test it, please help confirm that it works.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

koinec_yahoo.co.jp created this revision.

Attach the patch file created with the git format-patch command.

minsoochoo0122_proton.me added inline comments.
tools/kerneldoc/subsys/Doxyfile-dev_coredirector
19

We don't use LF at EOF.

tools/kerneldoc/subsys/Doxyfile-dev_coredirector
19

I aligned the endings of almost all other Doxyfiles in the same directory with LF.
Does this mean that newlines at the end are no longer necessary in the new coding style?

tools/kerneldoc/subsys/Doxyfile-dev_coredirector
19

Sorry, my bad. We use LF at EOF. You can ignore what I said.

LGTM, but as I said before, I prefer the name "hfi" than "coredirector"

koinec_yahoo.co.jp retitled this revision from coredirector - Intel TD/HFI driver - Part7: Add kerneldoc's Doxyfile to intelhfi - Intel TD/HFI driver - Part7: Add kerneldoc's Doxyfile.
  • Fix the driver name (coredirector -> intelhfi)
  • Fix file name with changed the driver name.