clock: Simplify subr_ticks and rename

[markj]

Summary

• We can use builtin constants for the size of int and long.
• The file should have a .S prefix since we want to run it through the preprocessor, though apparently this happens anyway with .s...

Reported by: jrtc27
Fixes: 6b82130e6c9a ("clock: Add a long ticks variable, ticksl")

[jrtc27]

Makefile.inc1

1773 ↗

(On Diff #149077)

If the window of time is small enough do we need to bother?...

sys/kern/subr_ticks.S

22

You missed the change to this line, otherwise it's wrong for 32-bit little endian.

25

As mentioned in my later follow-up, this should be .bss

[jrtc27]

sys/kern/subr_ticks.S

22

Uh, 32-bit *big* endian, even

[markj]

Remove the .depend cleanup hack, fix the TICKS_OFFSET definition, move to .bss.

[jrtc27]

(but please mention BSS in the commit message)

[kib]

sys/kern/subr_ticks.S

29

According to the gas document, arm .align n means something different from other arches .align n. This is why I suggested initially to use .p2align.

[jrtc27]

sys/kern/subr_ticks.S

29

Oh yeah. Use .balign. (.p2align works but it's more readable to use the actual number of bytes rather than log2)

[markj]

Makefile.inc1

1773 ↗

(On Diff #149077)

Probably not, I was just trying to suppress a one-time warning about a stale .depend.

sys/kern/subr_ticks.S

29

I avoided .p2align to keep the definitions a bit simpler, indeed. See D48430.