Page MenuHomeFreeBSD
Differential D48420

clock: Simplify subr_ticks and rename
ClosedPublic
Actions

Authored by markj on Jan 10 2025, 5:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 4, 5:52 AM
Unknown Object (File)
Mon, Jun 1, 5:33 PM
Unknown Object (File)
Mon, Jun 1, 4:36 PM
Unknown Object (File)
Mon, Jun 1, 5:10 AM
Unknown Object (File)
Sat, May 30, 12:35 PM
Unknown Object (File)
May 11 2026, 10:22 PM
Unknown Object (File)
May 11 2026, 9:27 PM
Unknown Object (File)
May 11 2026, 9:26 PM
View All Files
Subscribers
emaste

Details

Reviewers
jrtc27
olce
kib
imp
emaste
Commits
rGa267ceaf39a6: clock: Simplify subr_ticks and rename
rGb2b974f7ef4c: clock: Simplify subr_ticks and rename
Summary
  • We can use builtin constants for the size of int and long.
  • The file should have a .S prefix since we want to run it through the preprocessor, though apparently this happens anyway with .s...

Reported by: jrtc27
Fixes: 6b82130e6c9a ("clock: Add a long ticks variable, ticksl")

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markj created this revision.Jan 10 2025, 5:25 PM
Herald added a subscriber: emaste. · View Herald TranscriptJan 10 2025, 5:25 PM
markj requested review of this revision.Jan 10 2025, 5:25 PM
Harbormaster completed remote builds in B61650: Diff 149077.Jan 10 2025, 5:25 PM
jrtc27 added inline comments.Jan 10 2025, 5:32 PM
Makefile.inc1
1773 ↗(On Diff #149077)

If the window of time is small enough do we need to bother?...

sys/kern/subr_ticks.S
22

You missed the change to this line, otherwise it's wrong for 32-bit little endian.

25

As mentioned in my later follow-up, this should be .bss

jrtc27 added inline comments.Jan 10 2025, 5:34 PM
sys/kern/subr_ticks.S
22

Uh, 32-bit *big* endian, even

markj updated this revision to Diff 149078.Jan 10 2025, 5:37 PM
markj marked 3 inline comments as done.

Remove the .depend cleanup hack, fix the TICKS_OFFSET definition, move to .bss.

Harbormaster completed remote builds in B61651: Diff 149078.Jan 10 2025, 5:37 PM
jrtc27 accepted this revision.Jan 10 2025, 5:41 PM

(but please mention BSS in the commit message)

This revision is now accepted and ready to land.Jan 10 2025, 5:41 PM
emaste accepted this revision.Jan 10 2025, 5:45 PM
kib accepted this revision.Jan 10 2025, 6:17 PM
Closed by commit rGb2b974f7ef4c: clock: Simplify subr_ticks and rename (authored by markj). · Explain WhyJan 11 2025, 12:01 AM
This revision was automatically updated to reflect the committed changes.
markj added a commit: rGb2b974f7ef4c: clock: Simplify subr_ticks and rename.
kib added inline comments.Jan 11 2025, 5:16 AM
sys/kern/subr_ticks.S
29

According to the gas document, arm .align n means something different from other arches .align n. This is why I suggested initially to use .p2align.

jrtc27 added inline comments.Jan 11 2025, 6:37 AM
sys/kern/subr_ticks.S
29

Oh yeah. Use .balign. (.p2align works but it's more readable to use the actual number of bytes rather than log2)

markj added inline comments.Jan 11 2025, 5:00 PM
Makefile.inc1
1773 ↗(On Diff #149077)

Probably not, I was just trying to suppress a one-time warning about a stale .depend.

sys/kern/subr_ticks.S
29

I avoided .p2align to keep the definitions a bit simpler, indeed. See D48430.

markj added a commit: rGa267ceaf39a6: clock: Simplify subr_ticks and rename.Feb 14 2025, 7:27 PM

Revision Contents
Changeset List

PathSize
sys/
conf/
2 lines
kern/
subr_ticks.S
subr_ticks.s
22 lines

Diff 149107

View Options

sys/conf/files

Loading...
View Options

sys/kern/subr_ticks.S

Loading...
View Options

sys/kern/subr_ticks.s

Loading...