Page MenuHomeFreeBSD

Update OptionalObsoleteFiles.inc after 021385aba562
AcceptedPublic

Authored by arichardson on Sep 20 2021, 8:48 AM.

Details

Reviewers
emaste
dim
imp
Summary

I forgot to update this file so make delete-old would incorrectly remove
the newly-installed LLVM binutils. While touching the file also update
for 8e1c989abbd1 since ObsoleteFiles.inc now inludes the tablegen binaries.

Reported by: Herbert J. Skuhra <herbert@gojira.at>

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 41604
Build 38493: arc lint + arc unit

Event Timeline

tools/build/mk/OptionalObsoleteFiles.inc
1222

Is && correct? If CLANG is on but LLVM_BINUTILS is not we want to remove them?

tools/build/mk/OptionalObsoleteFiles.inc
1222

If MK_CLANG==yes and MK_LLVM_BINUTILS==no we should keep the files (same for MK_CLANG==no and MK_LLVM_BINUTILS==yes), so this condition should be correct?
Right now they are deleted in the second case.

tools/build/mk/OptionalObsoleteFiles.inc
1222

Oh, right - I misremembered how LLVM_BINUTILS works.

This revision is now accepted and ready to land.Sep 20 2021, 2:04 PM